-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency flutter to v3.24.1 #2420
Conversation
This sounds bad, I assume it is an upstream bug that should be fixed before we continue here? |
I would prefer to independently merge the package updates that are not necessary for updating the flutter version (should be rxdart, process_run and build_runner) and the pubspec.lock maintenance. |
I assume you validated that the analyzer correctly works again in neon_framework? |
This is an old bug that we also had before.
I've tried this to my best and could not find any issues. I forgot to bump the CI dart version. This is probably the reason it fails rn. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please fix the CI and also make sure to have a clean history of changes (so that we can properly revert if necessary).
sdk: ^3.0.0 | ||
sdk: ^3.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me it doesn't look like all the changes here are necessary.
fixes: #2391
replaces: #2399, #2404, #2415, #2400, #2406, #2397, #2398
Once reviewed, I'll sqash all commits together.
I had to disable custom_lint in our CI as it started analyzing files outside the package scope (mainly the symlinks to the pub cache with all our dependencies).
Now that we require dart 3.5 I'm looking into using dart workspaces.