Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken scrolling with Orca structural navigation in Firefox #2939

Open
3 tasks done
tyrylu opened this issue Nov 26, 2024 · 10 comments
Open
3 tasks done

Broken scrolling with Orca structural navigation in Firefox #2939

tyrylu opened this issue Nov 26, 2024 · 10 comments
Labels
bug frontend impact Javascript/Frontend code

Comments

@tyrylu
Copy link

tyrylu commented Nov 26, 2024

IMPORTANT

Read and tick the following checkbox after you have created the issue or place an x inside the brackets ;)

  • I have read the CONTRIBUTING.md and followed the provided tips
  • I accept that the issue will be closed without comment if I do not check here
  • I accept that the issue will be closed without comment if I do not fill out all items in the issue template.

Explain the Problem

Structural navigation with Orca wraps around in Firefox much sooner than it should.

Steps to Reproduce

Explain what you did to encounter the issue

  1. Have a list of unread news items
  2. Try navigating between them using the Go to next heading command of Orca, e. g. the H key (the 1 for level 1 headings works too)
  3. Observe that after four normal and an additional fifth article the Orca navigation wraps around

System Information

  • News app version: 5.0.2
  • Nextcloud version: 30.0.2
  • Cron type: Not relevant
  • PHP version: Not relevant, it is a front-end issue
  • Database and version: Not relevant, it is a front-end issue
  • Browser and version: Firefox 132.0.2
  • OS and version: current Arch Linux, but would be same on all Linux flavors

No errors in any logs, and surprisingly, this works in Chromium.

@tyrylu tyrylu added the bug label Nov 26, 2024
@wofferl
Copy link
Collaborator

wofferl commented Nov 27, 2024

Can you tell me which settings you are using and if this happens for all feeds/folders?
Are you using Normal view, compact view or expanded compact view?
Do you have reverse ordering active?
Is show all articles enabled?

@tyrylu
Copy link
Author

tyrylu commented Nov 27, 2024

Nothing from the default, e. g. normal view, and reverse and show all is disabled.
And yes, seems to happen in each folder (definitely happens for all articles).

@Grotax Grotax added the frontend impact Javascript/Frontend code label Nov 27, 2024
@wofferl
Copy link
Collaborator

wofferl commented Nov 27, 2024

Thanks, I will look at that.
You may also be interested in #2919, where we try to optimize things for screen readers.
And regarding your other issue (#2940) how you navigate to the article details.

@tyrylu
Copy link
Author

tyrylu commented Nov 27, 2024

Yeah, i saw that one, but in my experience, making one big issue usually does not bring the expected outcomes. For the links issue, I was referring to the text under the h1 of an article, if there's something (e. g. the intro-container div). You definitely can not get to a link in this text using the tab key, you can do that using up and down arrows, but the text definitely does not have the original link. And, is the hiding of the two buttons except for the share one using aria-hidden (and having them no labels either) intentional, by the way?

@wofferl
Copy link
Collaborator

wofferl commented Nov 27, 2024

Yeah, i saw that one, but in my experience, making one big issue usually does not bring the expected outcomes.

#2919 is not to making one big issue, but to discuss some things and helping to make the accessibility better.

@tyrylu
Copy link
Author

tyrylu commented Nov 27, 2024

Yeah, thanks for the headings back, that's for sure. By the way, the scrolling is broken regardless of the view type (tried all three), only the number of articles after which the wraparound occurs changes.

@wofferl
Copy link
Collaborator

wofferl commented Nov 28, 2024

Yeah, thanks for the headings back, that's for sure. By the way, the scrolling is broken regardless of the view type (tried all three), only the number of articles after which the wraparound occurs changes.

I could reproduce it. I made the article list recognizable as list for the screen reader, but unfortunately this doesn't fix the navigation.
Orca seems to have a problem with the dynamic loading of the list, so I need to dig deeper to debug this.

@tyrylu
Copy link
Author

tyrylu commented Nov 28, 2024

The event handling likely changed between v 25 and v 24, it worked flawlessly in 24. But thank you for looking into this issue. You should definitely get some events when Orca tries to update its virtual document position, but I don't know from top of my head which ones, they are likely different than in Chromium as well.

@wofferl
Copy link
Collaborator

wofferl commented Nov 28, 2024

The problem is that orca starts over when the first items are removed from the scroll list. I have tried different things that should help with that, unfortunately without success.
I opened an issue at orca / gnome structural navigation don't work in dynamic scroll lists
to hopefully get some help here.

News 24 worked here because the scroll never had an item removed from the scroll list, which has made the performance worse as longer you have used a list.

@tyrylu
Copy link
Author

tyrylu commented Nov 29, 2024

Yeah, at least on Windows with NVDA, I can also confirm the performance degradation. And yes, this might require Orca changes, we'll see, thank you for reporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug frontend impact Javascript/Frontend code
Projects
None yet
Development

No branches or pull requests

3 participants