Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement purgeUnread setting #1931

Merged
merged 2 commits into from
Oct 8, 2022
Merged

Implement purgeUnread setting #1931

merged 2 commits into from
Oct 8, 2022

Conversation

Grotax
Copy link
Member

@Grotax Grotax commented Oct 8, 2022

This implements a new admin setting, allowing the admin to configure news to also delete unread items with every update.

Fixes #110

@Grotax Grotax force-pushed the feature/purge_unread branch 4 times, most recently from cac1fd4 to 802d52b Compare October 8, 2022 13:06
@Grotax

This comment was marked as resolved.

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax force-pushed the feature/purge_unread branch from 802d52b to da02122 Compare October 8, 2022 13:22
@Grotax Grotax marked this pull request as ready for review October 8, 2022 13:22
Copy link
Contributor

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Grotax

src/components/AdminSettings.vue Outdated Show resolved Hide resolved
Co-authored-by: Sean Molenaar <SMillerDev@users.noreply.github.com>
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax merged commit 931fcc1 into master Oct 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the feature/purge_unread branch October 8, 2022 15:29
Grotax added a commit that referenced this pull request Oct 10, 2022
Changed
- New administrator setting for deleting unread items automatically (#1931)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax mentioned this pull request Oct 10, 2022
Grotax added a commit that referenced this pull request Oct 11, 2022
Changed
- New administrator setting for deleting unread items automatically (#1931)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Grotax added a commit that referenced this pull request Oct 11, 2022
Changed
- New administrator setting for deleting unread items automatically (#1931)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Emporea
Copy link

Emporea commented Oct 22, 2022

So to understand this correctly: before this merge the included autopurge would only delete already read articles?
Even if I have lets say 100,000 unread articles?

@Grotax
Copy link
Member Author

Grotax commented Oct 22, 2022

Yes, well it is still the default. You have to enable it.

We are also not a 100% sure how many articles are kept but it will be around that number that you enter.
Maybe a few more or less per feed. But not 200 vs 100.000 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autopurging does not delete unread news items
3 participants