Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): fix tsconfig out dir typings #562

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

skjnldsv
Copy link
Contributor

Fix #561
We need to use the tsconfig, or else it's no use at all.
Removing the overriden declaration in rollup make the rollup plugin fetch the tsconfig.json file

$ npm run build 
$ tree dist
dist
├── date.d.ts
├── gettext.d.ts
├── gettext.js
├── gettext.mjs
├── index.d.ts
├── index.js
├── index.mjs
├── registry.d.ts
└── translation.d.ts

0 directories, 9 files

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added the bug Something isn't working label Jan 19, 2023
@skjnldsv skjnldsv self-assigned this Jan 19, 2023
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally those options should override the tsconfig options and not replace the whole config. But this works so 👍

@ChristophWurst ChristophWurst merged commit 4f53d4f into master Jan 19, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/typings-tsconfig branch January 19, 2023 09:04
@skjnldsv
Copy link
Contributor Author

Normally those options should override the tsconfig options and not replace the whole config. But this works so +1

Are you sure?
Seeing the drastic change in behaviour from this single line removal, it seems it's replacing entirely, no?

@skjnldsv skjnldsv mentioned this pull request Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong typings location
3 participants