Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nc-update-nextcloud does not prevent updating to unsupported versions #1935

Open
HansCronau opened this issue May 20, 2024 · 2 comments
Open

Comments

@HansCronau
Copy link

At the time of writing the latest version of NC supported by NCP (1.54.0) is 28.0.5.
I would therefore expect nc-update-nextcloud to not update past this version, or at least throw a warning.
Instead it is possible to (accidentally) enter "29.0.0" and the update will just start running without warning.
(If this behavior is intended, I think documentation could be improved to better explain why this will not cause issues.)

@theCalcaholic
Copy link
Collaborator

theCalcaholic commented May 21, 2024

Well it is intended but may cause issues. If you want to update to the latest supported version, you can simply enter "0". If you enter a specific version, it will perform the upgrade as requested.

I think this is mostly a UX issue that will be resolved once I get around to rewriting the web interface.

@HansCronau
Copy link
Author

@theCalcaholic Thanks for your comment and amazing work.

I should probably have noted that the observation goes for both the web UI as the terminal application ncp-config, which I was using.

Because updating to the latest supported version (using "0") is not possible when a machine is multiple majors behind, I was manually updating it to "27.0.0", "28.0.0", "29.0.0", "Wait... That one shouldn't even be supported, right?" Double checks release notes while update to NC29 is running. "No, I think it shouldn't. So... whoops?"
But if not, why had it just started, without warning? This created the tiniest bit of doubt for me: Did I misunderstand something about nc-update-nextcloud? I'm glad to learn I didn't and this is indeed mostly a UX issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants