Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toolbar to native markdown editor #788

Open
2 of 5 tasks
newhinton opened this issue Dec 4, 2021 · 6 comments · May be fixed by #790
Open
2 of 5 tasks

Add toolbar to native markdown editor #788

newhinton opened this issue Dec 4, 2021 · 6 comments · May be fixed by #790
Assignees
Labels
feature request Requests for complete new features needs discussion Need to clarify if and how we should implement this

Comments

@newhinton
Copy link
Contributor

newhinton commented Dec 4, 2021

Is your feature request related to a problem? Please describe.
It's an improvement for people who are not that fluent in in markdown syntax.

Describe the solution you'd like
grafik

Additional context
#785 (comment)
This is similar to the toolbar nextcloud/text provides

I already started working on this, PR' follows later.

Todo:

  • Add missing/proper icons
  • Make icon and text the same color
  • handle "Unsaved/Saving/Saved/Last Modified"-State below original toolbars
  • fix toolbar for mobile
  • remove original threedot menu (or at least make it fit the new toolbar handling, exposing the most useful items)

In my trials i also centered the content properly. It is not anchored to the left sidebar anymore, so that the content stays centered. This is useful for wide screens

@newhinton newhinton added needs discussion Need to clarify if and how we should implement this feature request Requests for complete new features labels Dec 4, 2021
@newhinton newhinton self-assigned this Dec 4, 2021
@newhinton newhinton linked a pull request Dec 6, 2021 that will close this issue
@newhinton
Copy link
Contributor Author

newhinton commented Dec 6, 2021

grafik

This is how it looks like with proper icons. I am currently waiting for text#1996 so that we know if we can use all their icons. Most of them are from https://google.github.io/material-design-icons/ so we should be fine since it uses Apache 2 if we stick to that license

As to the new image upload/selection: I think with this toolbar we can easily do both.
The nextcloud-native selector gets a prominent icon in the toolbar, and upload-from-local is moved as an option to the overhang menu. that way we have both, but do not clutter the ui

@dodedodo
Copy link

I'd love to see a toolbar in the editor. But why not just use the nextcloud 'text' markdown editor as a whole?

nextcloud/text #884 has some more info on this. Nextcloud Collectives has already implemented text as its markdown editor.

@newhinton
Copy link
Contributor Author

newhinton commented Feb 24, 2022

@dodedodo Because the "markdown-editor" the text app uses is deeply flawed. It reliably breaks markdown files and does not adhere to 'standards' and conventions. Until it stops beeing destructive it will probably not replace the one we use. I will link to the discussion later that explains the issue more deeply

Edit:

Here is the link to the discussion: nextcloud/text#593

@szaimen
Copy link
Contributor

szaimen commented Sep 15, 2022

@dodedodo Because the "markdown-editor" the text app uses is deeply flawed. It reliably breaks markdown files and does not adhere to 'standards' and conventions. Until it stops beeing destructive it will probably not replace the one we use. I will link to the discussion later that explains the issue more deeply

Edit:

Here is the link to the discussion: nextcloud/text#593

This is now mostly resolved for NC25 IIRC

@szaimen

This comment was marked as off-topic.

@stefan-niedermann

This comment was marked as off-topic.

@joshtrichards joshtrichards changed the title Add toolbar to webeditor Add toolbar to native markdown editor Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for complete new features needs discussion Need to clarify if and how we should implement this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants