Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notification bell does not adapt to theme, always white #1962

Closed
blizzz opened this issue Jun 28, 2024 · 3 comments · Fixed by nextcloud-libraries/nextcloud-vue#5747
Closed

Comments

@blizzz
Copy link
Member

blizzz commented Jun 28, 2024

Steps to reproduce

  1. Run notifications from master
  2. Have a background that will have icons black, also dark mode
  3. Look at the notification bell

Expected behaviour

The bell is black

Actual behaviour

It is an old, white bell

Screenshot_20240628_221929

This also happened after increasing the cachebuster, and also when switiching to light mode (all icons are black, but the bell)

I have not seen a similar bug report so far. Apologies if I oversaw one.

cc @Antreesy

@nickvergessen
Copy link
Member

Can you share the image and the theming color?

@Antreesy
Copy link
Collaborator

Found related server change for 29, but it wasn't backported to main: nextcloud/server#45430

UnifiedSearch and ContactsMenu have this internal style, Notifications App doesn't

#header .header-menu__trigger-icon {
    color: var(--color-background-plain-text) !important;
}

Plain solution would be to add it, but whenever next change comes, we need to fix it again in three different places
So I'd say, should be fixed in vue-library? (cc @susnux )

@blizzz
Copy link
Member Author

blizzz commented Jul 2, 2024

Can you share the image and the theming color?

If still relevant, it is one of the shipped images:

Screenshot_20240702_113540

Dark mode (via system pref), and primary color is Nextcloud blue / #006789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants