Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV]: Ensures [role="img"] elements have alternate text or hide it from a11y tree #2240

Closed
JuliaKirschenheuter opened this issue Jan 8, 2024 · 8 comments
Closed

[BITV]: Ensures [role="img"] elements have alternate text or hide it from a11y tree #2240

JuliaKirschenheuter opened this issue Jan 8, 2024 · 8 comments
Assignees
@Pytal
Labels
3. to review Waiting for reviews a11y28checked needed for a11y accessibility

Comments

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Jan 8, 2024 •
edited
Loading

Go to the index.php/apps/photos/folders and create a folder.

Please add aria-hidden="true" to this <span>

Screenshot from 2024-01-08 18-37-42
@JuliaKirschenheuter JuliaKirschenheuter added 1. to develop Accepted and waiting to be taken care of accessibility labels Jan 8, 2024
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jan 8, 2024
@JuliaKirschenheuter
Copy link
Contributor Author

@artonge confirmed i can remove role="img"

@JuliaKirschenheuter JuliaKirschenheuter removed their assignment Jan 11, 2024
@ChristophWurst
Copy link
Member

Dropping the attribute is all there is to do?

@JuliaKirschenheuter JuliaKirschenheuter changed the title [BITV]: Ensures [role="img"] elements have alternate text [BITV]: Ensures [role="img"] elements have alternate text or hide it from a11y tree Jan 11, 2024
@JuliaKirschenheuter
Copy link
Contributor Author

Dropping the attribute is all there is to do?

Please add aria-hidden="true" to this

@GretaD GretaD self-assigned this Jan 11, 2024
@GretaD GretaD mentioned this issue Jan 11, 2024
Closed
@ChristophWurst ChristophWurst moved this to 🏗️ In progress in 💌 📅 👥 Groupware team Jan 16, 2024
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jan 16, 2024
@susnux
Copy link
Contributor

susnux commented Jan 23, 2024

0dc150b

@susnux susnux closed this as completed Jan 23, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Jan 23, 2024
@szaimen
Copy link
Contributor

szaimen commented Jan 26, 2024

I am not sure if this implementation is completely correct:
image
Also see what happens on focus-visible and mouse focus:
image

Aufzeichnung.2024-01-26.100112.mp4

@szaimen szaimen reopened this Jan 26, 2024
@github-project-automation github-project-automation bot moved this from ☑️ Done to 📄 To do in 💌 📅 👥 Groupware team Jan 26, 2024
@GretaD
Copy link

GretaD commented Jan 26, 2024

i will have another look

@JuliaKirschenheuter JuliaKirschenheuter assigned Pytal and unassigned GretaD Jan 26, 2024
@JuliaKirschenheuter
Copy link
Contributor Author

still need a backport to stable28: #2274

@JuliaKirschenheuter
Copy link
Contributor Author

i will have another look

Thanks, but this is already done

@szaimen szaimen added the a11y28checked needed for a11y label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews a11y28checked needed for a11y accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure that the role img elements have aria label nextcloud/photos
6 participants
@ChristophWurst @susnux @JuliaKirschenheuter @GretaD @Pytal @szaimen