From 4b333e1b404077c8ec1a11e39ac8ef6a132a77ad Mon Sep 17 00:00:00 2001 From: Julius Knorr Date: Tue, 10 Sep 2024 09:43:42 +0200 Subject: [PATCH] fix: Only write once to template instead of create/copy Signed-off-by: Julius Knorr --- lib/private/Files/Template/TemplateManager.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/private/Files/Template/TemplateManager.php b/lib/private/Files/Template/TemplateManager.php index 3f3c36de5f151..46fd428b491db 100644 --- a/lib/private/Files/Template/TemplateManager.php +++ b/lib/private/Files/Template/TemplateManager.php @@ -159,11 +159,9 @@ public function createFromTemplate(string $filePath, string $templateId = '', st throw new GenericFileException($this->l10n->t('Invalid path')); } $folder = $userFolder->get(dirname($filePath)); - $targetFile = $folder->newFile(basename($filePath)); $template = null; if ($templateType === 'user' && $templateId !== '') { $template = $userFolder->get($templateId); - $template->copy($targetFile->getPath()); } else { $matchingProvider = array_filter($this->getRegisteredProviders(), function (ICustomTemplateProvider $provider) use ($templateType) { return $templateType === get_class($provider); @@ -171,9 +169,9 @@ public function createFromTemplate(string $filePath, string $templateId = '', st $provider = array_shift($matchingProvider); if ($provider) { $template = $provider->getCustomTemplate($templateId); - $template->copy($targetFile->getPath()); } } + $targetFile = $folder->newFile(basename($filePath), ($template instanceof File ? $template->fopen('rb') : null)); $this->eventDispatcher->dispatchTyped(new FileCreatedFromTemplateEvent($template, $targetFile)); return $this->formatFile($userFolder->get($filePath)); } catch (\Exception $e) {