From 88648fa4935d5133e436b9ceb3ce559116fe7a30 Mon Sep 17 00:00:00 2001 From: "Simon L." Date: Tue, 14 May 2024 12:09:15 +0200 Subject: [PATCH] Revert: "Check datadirectory owner, not config owner." Signed-off-by: Simon L --- console.php | 27 ++++++++------------------- cron.php | 8 ++++---- 2 files changed, 12 insertions(+), 23 deletions(-) diff --git a/console.php b/console.php index a4ab13f5e6c31..693a2618a8886 100644 --- a/console.php +++ b/console.php @@ -41,28 +41,17 @@ function exceptionHandler($exception) { exit(1); } - // Check if the data directory is available and the server is installed - $dataDirectory = $config->getSystemValueString('datadirectory', \OC::$SERVERROOT . '/data'); - if ($config->getSystemValueBool('installed', false) && !is_dir($dataDirectory)) { - echo "Data directory (" . $dataDirectory . ") not found" . PHP_EOL; + $user = posix_getuid(); + $configUser = fileowner(OC::$configDir . 'config.php'); + if ($user !== $configUser) { + echo "Console has to be executed with the user that owns the file config/config.php" . PHP_EOL; + echo "Current user id: " . $user . PHP_EOL; + echo "Owner id of config.php: " . $configUser . PHP_EOL; + echo "Try adding 'sudo -u #" . $configUser . "' to the beginning of the command (without the single quotes)" . PHP_EOL; + echo "If running with 'docker exec' try adding the option '-u " . $configUser . "' to the docker command (without the single quotes)" . PHP_EOL; exit(1); } - // Check if the user running the console is the same as the user that owns the data directory - // If the data directory does not exist, the server is not setup yet and we can skip. - if (is_dir($dataDirectory)) { - $user = posix_getuid(); - $dataDirectoryUser = fileowner($dataDirectory); - if ($user !== $dataDirectoryUser) { - echo "Console has to be executed with the user that owns the data directory" . PHP_EOL; - echo "Current user id: " . $user . PHP_EOL; - echo "Owner id of the data directory: " . $dataDirectoryUser . PHP_EOL; - echo "Try adding 'sudo -u #" . $dataDirectoryUser . "' to the beginning of the command (without the single quotes)" . PHP_EOL; - echo "If running with 'docker exec' try adding the option '-u " . $dataDirectoryUser . "' to the docker command (without the single quotes)" . PHP_EOL; - exit(1); - } - } - $oldWorkingDir = getcwd(); if ($oldWorkingDir === false) { echo "This script can be run from the Nextcloud root directory only." . PHP_EOL; diff --git a/cron.php b/cron.php index 9b0489653efd0..be743664db2ba 100644 --- a/cron.php +++ b/cron.php @@ -130,11 +130,11 @@ } $user = posix_getuid(); - $dataDirectoryUser = fileowner($config->getSystemValueString('datadirectory', \OC::$SERVERROOT . '/data')); - if ($user !== $dataDirectoryUser) { - echo "Cron has to be executed with the user that owns the data directory" . PHP_EOL; + $configUser = fileowner(OC::$configDir . 'config.php'); + if ($user !== $configUser) { + echo "Console has to be executed with the user that owns the file config/config.php" . PHP_EOL; echo "Current user id: " . $user . PHP_EOL; - echo "Owner id of the data directory: " . $dataDirectoryUser . PHP_EOL; + echo "Owner id of config.php: " . $configUser . PHP_EOL; exit(1); }