-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout of admin tag management needs adjustments #10420
Comments
In the creation flow, the x is not really necessary. It is much too dangerous to put a destructive action next to the confirm action too. In the editing process, we should have a Save button (Ideally also with text) and a 3-dot menu with the other options in it. |
In NC13 we had normal text buttons, so they where a bit bigger and no real problem. Since that is the "breaking" PR, let's summon the author @juliushaertl |
@jancborchardt So should we just move back to the regular buttons again? We don't have any buttons with images anywhere in the settings ui as far as i can tell. How about having the create a new tag ui persistent with just a confirm button. That way we could get rid of the reset button when editing and would just have save and delete there. Delete could go into a 3 dots menu. Of course the buttons should all have a width of 44x44px, not small as they are right now. |
Since we are currently in FF and trying to finalize the product, I'd say let's do the simple step (text-buttons) for 14 and change to whatever is best in 15. |
The "icon buttons" are too close together:
Even worse with the delete button on edit:
cc @nextcloud/designers
The text was updated successfully, but these errors were encountered: