issues with custom color and dark theme

[violoncelloCH]

Steps to reproduce

1. activate dark theme
2. change color in theming and see dark theme being disabled temporarly
3. go back to files and see only folder icons in new color, top bar in nextcloud blue and dark theme being applied in a strange way (see screenshot)
   

Server configuration

Nextcloud version: NC 14.0.0 beta1

Updated from an older Nextcloud/ownCloud or fresh install: updated

Client configuration

Browser: Firefox

[nextcloud-bot]

GitMate.io thinks possibly related issues are #7401 (Theming on light color), #3211 (Inputs have wrong border color with theming), #4896 (Search results and theme color), #7071 (Missing icons at custom theme-color (Theming-App)), and #4137 (Custom location for themes).

[nickvergessen]

A hard refresh is needed and should do the trick.

Seems like we are missing an increment on the scss version variable?

[violoncelloCH]

@nickvergessen what kind of hard refresh do you mean? - a browser refresh dosen't help

after re-setting a different color with dark theme disabled, the top bar stays nextcloud-blue

[violoncelloCH]

ahh, without having dark theme enabled, adding an app which places an icon in the top bar did the refresh, but this doesn't work for dark theme

[rullzer]

@nextcloud/theming

[juliusknorr]

We need to inject variables that come from the OCP\Defaults class in the accessibility app as well https://github.com/nextcloud/server/blob/master/apps/accessibility/lib/Controller/AccessibilityController.php#L144

similar to

server/lib/private/Template/SCSSCacher.php

Line 289 in 6686ca9

$this->getInjectedVariables() .

cc @skjnldsv

[skjnldsv]

Fix in #10689

[violoncelloCH]

for me this issue still exists in RC1
it looks still the same as in the screenshot I posted
related to or same as #10960