Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White area at the bottom of public share pages without footer #10641

Closed
danxuliu opened this issue Aug 10, 2018 · 1 comment
Closed

White area at the bottom of public share pages without footer #10641

danxuliu opened this issue Aug 10, 2018 · 1 comment
Assignees
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. regression
Milestone

Comments

@danxuliu
Copy link
Member

The min-height of #content is always set to 100vh - 160px, even when there is no footer; as height is also set to initial the height of the content only expands to the minimum height, and thus does not vertically fill the whole page.

public-share-pdf-viewer

public-share-rich-documents

This could be overridden in the affected apps (at least, PDF viewer and Rich Documents, but there may be others), but it would be better to fix it in the server to fix it once, fix it everywhere ;-)

@nextcloud/designers

@danxuliu danxuliu added bug design Design, UI, UX, etc. regression labels Aug 10, 2018
@danxuliu danxuliu added this to the Nextcloud 14 milestone Aug 10, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #9434 (Public Sharing), #1125 (Drag'n'drop not working on public share page anymore), #5986 (Public share middleware), #4020 (Search on public share pages), and #603 (Video sizing on the public share page).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. regression
Projects
None yet
Development

No branches or pull requests

4 participants