Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower button cut off in the destination folder dialog #11315

Closed
j-ed opened this issue Sep 21, 2018 · 7 comments
Closed

Lower button cut off in the destination folder dialog #11315

j-ed opened this issue Sep 21, 2018 · 7 comments
Assignees
Labels
Milestone

Comments

@j-ed
Copy link
Contributor

j-ed commented Sep 21, 2018

Expected behavior

If files are copied or moved to a new folder, all displayed buttons in the destination folder dialog should be correctly displayed without the requirement to scroll down the dialog window.

Current behavior

The lower button is cut off in the initially displayed destination folder dialog. You need to scroll down to get it displayed correctly.

2018092_nc_copy_move_dialog

Steps to reproduce

  1. Select two files to be copied
  2. Navigate to the destination folder.
  3. Check out how the buttons are displayed.

Environment

Server Configuration

OS: Linux 3.16.57
Web server: Apache2 2.4.33
Database: MariaDB 10.0.32
PHP version: 5.6.34
Nextcloud version: 13.0.6

Client Configuration

Browser: Mozilla Firefox 62.0
Operating system: Windows 10

@nextcloud-bot nextcloud-bot added design Design, UI, UX, etc. feature: files labels Sep 21, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #10897 (Buttons overlaps scrollbar in "Target folder" dialog), #2245 (Folder name input cut off), #10679 (switches the oc dialog button row to flex), #6375 (Favicon cut off on the right), and #7588 (Folder permissions).

@weeman1337 weeman1337 self-assigned this Sep 22, 2018
@weeman1337
Copy link
Member

@j-ed thanks for the report.

I can confirm the problem with Nextcloud 13.

It's not perfect in dev and 14, but it works:
image

I'll have a look.

@weeman1337
Copy link
Member

The buttons could even have more than two lines if the name is long enough. I would suggest going for the text overflow ellipsis here:

image

@nextcloud/designers any opinions here?

@skjnldsv
Copy link
Member

@weeman1337 the last one is great I think :)

@pixelipo
Copy link
Contributor

Why doesn't the button just simply say one of the following?

  • "Move/Copy here"
  • "Move/Copy to this folder"
  • "Move/Copy to current folder"

@weeman1337
Copy link
Member

I could imagine the folder name in the buttons is to make it clear where the file goes to.

@MorrisJobke
Copy link
Member

Fixed by #11522

@MorrisJobke MorrisJobke added this to the Nextcloud 15 milestone Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants