-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename 'enable'-checkbox for linksharing in filesapp-details #11634
Comments
@nextcloud/designers |
This is not a Github issue, rather a translation issue. Translations are done on Transifex, please join and find the string and translate it correctly. Regarding the English wording, I'm not sure what it says now. @MariusBluem Do you know? |
In english it's currently 'enable'. So, the translation in itself is not wrong, but i think to a user something different would be better, maybe 'share'/'unshare', depending on the state? |
Also a button instead of a checkbox could improve the share-ability. As of now, it may not be obvious for every user how to share a link with somebody outside of the nextcloud-instance |
@jancborchardt what do you think? |
Why don't we get rid of the checkbox and just make the whole "Share link" entry clickable to enable link sharing. For disabling the link share we could simply add an entry to the popover menu. Edit: we might need to adjust the wording a bit to make it clear what the state is: |
AFAIK @jancborchardt or @skjnldsv already worked on a renaming, but I couldn't find the PR that changes this. There is a screenshot in #11537 (comment) |
We are working on it at #11537 The "Enable" part will be removed completely. We will move the checkbox towards the "Share link" part. And "Copy link" will be visible directly, outside of the menu. Also, when you check the "Share link", the link will be copied directly and feedback given in the form of a popover. @newhinton if you want to check out #11537 and help you are very welcome! :) @skjnldsv and me are still focused on grid view at the moment. |
Currently if you want to activate a link, you need to tick a checkbox. I think 'enable' is not quiet a good description for sharing a link.
Maybe 'share'/'unshare' would be a better description?
The text was updated successfully, but these errors were encountered: