Files external app is abusing Namespace of the External app

[nickvergessen]

The JS code of the files_external app must not be in OCA.External.
That namespace belongs to the external app:

server/apps/files_external/js/app.js

Line 20 in 440b5c9

OCA.External.App = {

https://github.com/nextcloud/external/blob/6d96ef757933a2fe3527da50e6e3831f93104b50/js/admin.js#L90

[nickvergessen]

@nextcloud/javascript should be fine to just replace it everywhere?

[nextcloud-bot]

GitMate.io thinks possibly related issues are #2770 (Files External tests failing), #10330 (Files App: Layout issue when selecting multiple files), #3468 (Update detection issues for files external), #2962 (No icon for files and folders in file app), and #5142 (Files app not showing files).