Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework of collaborative tags (NC 12.0) #1465

Closed
5 of 9 tasks
nickvergessen opened this issue Sep 20, 2016 · 8 comments
Closed
5 of 9 tasks

Rework of collaborative tags (NC 12.0) #1465

nickvergessen opened this issue Sep 20, 2016 · 8 comments

Comments

@nickvergessen
Copy link
Member

nickvergessen commented Sep 20, 2016

@raimund-schluessler
Copy link
Member

I would like to be able to give tags a custom color so it is easier to distinguish between different tags.
@jancborchardt Might this be useful?

@MorrisJobke
Copy link
Member

@nickvergessen Could I ask you to split out the stuff that doesn't make it into 11 to a separate ticket for 12? Thanks ;)

@disaster123
Copy link

@raimund-schluesser great! Need that too. Any chance to implement it?

@nickvergessen nickvergessen changed the title Make collaborative tags great again Rework of collaborative tags Feb 1, 2017
@WowMuchName
Copy link

WowMuchName commented Mar 20, 2017

Aren't the hidden-public-restricted access-types very limited and only scratching the surface of a deeper problem?

For instance we have a group User and a group Manager. When Users upload stuff the workflow module assigns a "to be checked" tag. After the Managers check the files the tag is removed. With things as they are Managers either need to be Admins or the tag needs to be public. Both options aren't very good. Currently we rely on the fact that tag-removal is logged and just have the tag public.

Couldn't each collaborative Tag be treated with the same access mechanism used for files? Where users can give "see Tag" (read), "set Tag" (write), "remove Tag" (delete), "Can reshare" privileges to other users and groups as they do with files? Inheriting all the "reshare only in the same group" etc. settings that are used for files?

I would assume a lot of the logic and ui components already used for files could be reused here. Having one concept of a "secureable object" and Files, Tags, Adressbooks, Calendars etc. just extending upon that concept seems a good idea for both usability and maintainability. It is also how most operating systems and security frameworks organize things.

At any rate giving tags some-sort-of-access-rights-but-not-really seems like re-inventing an inferior wheel when a battle proven one is already used elsewhere in the code.

@Spartachetto
Copy link

@WowMuchName I have the impression that there is some misunderstanding...

If I am not wrong #2512 is about another aspect of tag management: you are talking about assigning and removing (i.e.: "un-assigning") tags to files; #2512 is about deleting tags from the list of tags, i.e.: removing tags from the system.
To say it with other words, if someone deletes the "to be checked" tag then the only way to assign it to a file is to recreate another tag with the same label.

@WowMuchName
Copy link

WowMuchName commented Mar 23, 2017

@Spartachetto You are correct, I jumped to conclusions there and should have actually read the issue before linking it. I was referring to the hidden-public-restricted access-types you can set for tags which I find to be very limited.

I updated my original comment accordingly

@MorrisJobke
Copy link
Member

@nickvergessen I think the remaining items needs to be pushed to 13, right? Could you create a ticket for them? To know what was implemented in which version.

@MorrisJobke
Copy link
Member

I moved the pending items to a dedicated 13 issue: #4699

@MorrisJobke MorrisJobke changed the title Rework of collaborative tags Rework of collaborative tags (NC 12.0) May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants