Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search in apps view broken, if multiple authors are specified #1563

Closed
irgendwie opened this issue Sep 28, 2016 · 4 comments
Closed

Search in apps view broken, if multiple authors are specified #1563

irgendwie opened this issue Sep 28, 2016 · 4 comments
Labels
bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in. low

Comments

@irgendwie
Copy link
Member

irgendwie commented Sep 28, 2016 •
edited
Loading

The search function is broken for the apps view, if an app has multiple authors specified.
This seems to be allowed? according to https://nextcloudappstore.readthedocs.io/en/latest/developer.html#info-xml (@BernhardPosselt)

The reason for this is the following line:
https://github.com/nextcloud/server/blob/master/settings/js/apps.js#L516

In case of multiple <author> in a appinfo/info.xml file, at the specified line, author is an array, instead of a string and therefore toLowerCase() fails.

One example app, which is using multiple <author>: https://gitlab.com/eneiluj/gpxpod-oc
@MorrisJobke MorrisJobke added bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in. low labels Sep 28, 2016
@vgvenkat
Copy link

vgvenkat commented Oct 8, 2016

Can I try this one? I guess adding an isString check would do?

@juliusknorr
Copy link
Member

juliusknorr commented Oct 8, 2016 •
edited
Loading

@vgvenkat Sure, that would be great. Just open a pull request with the supposed changes and if you have any questions or need some help, just ask.

@vgvenkat
Copy link

vgvenkat commented Oct 10, 2016 •
edited
Loading

Does this commit acd9066 handle this issue? It seems to have been committed 10 days ago.

@juliushaertl any update on this please?

@nickvergessen
Copy link
Member

Yes this is already fixed

@nextcloud-bot nextcloud-bot mentioned this issue Jul 31, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in. low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nickvergessen @MorrisJobke @vgvenkat @juliusknorr @irgendwie