Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files sidebar sharee/share owner action menu cut off #18634

Closed
wiswedel opened this issue Jan 2, 2020 · 8 comments · Fixed by nextcloud-libraries/nextcloud-vue#831 or #24331
Closed
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug design Design, UI, UX, etc. feature: file sidebar Related to the file sidebar component needs info

Comments

@wiswedel
Copy link
Contributor

wiswedel commented Jan 2, 2020

Click on a sharee's or share owner's profiile picture in the sharing sidebar reveals a contacting action menu - which is cut off on the left side. The main files frame is overlaying it.

abgeschnitten

cc @nextcloud/designers

@wiswedel wiswedel added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap feature: file sidebar Related to the file sidebar component 18-feedback design Design, UI, UX, etc. labels Jan 2, 2020
@skjnldsv
Copy link
Member

skjnldsv commented Jan 2, 2020

AH yep :/
Should be fixed by nextcloud-libraries/nextcloud-vue#641, right @ma12-co ?

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 2, 2020
@rullzer rullzer added this to the Nextcloud 18 milestone Jan 2, 2020
@marcoambrosini
Copy link
Member

Should be fixed by nextcloud-libraries/nextcloud-vue#641, right @ma12-co ?

Yes but it also requires the menuPosition prop to be specified in the files app

@jancborchardt
Copy link
Member

The menuPosition is fine to be centered, it’s only the overlay that needs to be fixed. :)

@marcoambrosini
Copy link
Member

The menuPosition is fine to be centered, it’s only the overlay that needs to be fixed. :)

Do you mean the z-index? If so then nextcloud-libraries/nextcloud-vue#641 doesn't help here.
Btw if we do this in the right sidebar, shouldn't we treat the action-menu in the left sidebar in the same way? Atm the menu is left aligned so that it doesn't invade the app content
Screenshot_20200109_104406

@rullzer rullzer modified the milestones: Nextcloud 18.0.2, Nextcloud 18.0.3 Mar 11, 2020
@rullzer rullzer modified the milestones: Nextcloud 18.0.3, Nextcloud 18.0.4 Mar 23, 2020
@skjnldsv
Copy link
Member

Fixed by nextcloud-libraries/nextcloud-vue#831

@wiswedel
Copy link
Contributor Author

wiswedel commented Mar 5, 2021

This has been fixed only half.
The sharees are fine now. The share owner from the view of a sharee (see the gif in the original post) are still broken.
Reproduced with 20.0.4 and 21.0.0

@wiswedel wiswedel reopened this Mar 5, 2021
@wiswedel wiswedel changed the title [18beta4] files sidebar sharee/share owner action menu cut off files sidebar sharee/share owner action menu cut off Mar 5, 2021
@szaimen szaimen added needs info 0. Needs triage Pending check for reproducibility or if it fits our roadmap and removed 1. to develop Accepted and waiting to be taken care of labels Nov 26, 2022
@szaimen
Copy link
Contributor

szaimen commented Nov 26, 2022

Hi, please update to at least 23.0.12 and report back if it fixes the issue. Thank you!

@nextcloud-command
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

@nextcloud-command nextcloud-command added the stale Ticket or PR with no recent activity label Jan 22, 2023
@nextcloud-command nextcloud-command removed stale Ticket or PR with no recent activity needs info labels Jan 26, 2023
@szaimen szaimen closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug design Design, UI, UX, etc. feature: file sidebar Related to the file sidebar component needs info
Projects
None yet
9 participants