Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Color of Birthday Calendar #2965

Closed
der-daniel opened this issue Jan 6, 2017 · 31 comments
Closed

Change Color of Birthday Calendar #2965

der-daniel opened this issue Jan 6, 2017 · 31 comments
Labels
bug design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.

Comments

@der-daniel
Copy link
Member

Hi,

referencing this issue: nextcloud/calendar#274, I want to suggest a possibility of changing the colors of the birthday calendar.

It neither readable in my browser nor on my android device.

Moreover I would really appreciate a way to change colors of calendars with a convenient color picker. So far I only have like 10 colors to choose from.

Cheers

@MorrisJobke
Copy link
Member

cc @jancborchardt

@Tarry91
Copy link

Tarry91 commented Feb 20, 2017

I just want to add my +1 here :)

@j-ed
Copy link
Contributor

j-ed commented Mar 2, 2017

👍 With the Calendar app v1.5.1 a new, enhanced color picker has been introduced to set individual calendar colors, which should be used to set the color of a birthday calendar too.

@Luticus
Copy link

Luticus commented Mar 3, 2017

I'm running the newest version of the calendar as well as the newest nextcloud and I cannot change the color of the birthday calendar. Mine is stuck on this really bright color which then becomes unreadable on my android calendar widget (which syncs color with nextcloud)

@linuxpete
Copy link

Using Nextcloud 11.0.1 and calendar 1.5.1. Change of color not possible. Would help if color at least is darker then yellow.

@MariusBluem
Copy link
Member

MariusBluem commented Mar 5, 2017

What about giving birthdays no color and indicate them instead with a 🎁 (for frontend @georgehrke) ... This is what Apple does 😁

@linuxpete
Copy link

Well yes, could be but then a birthday doesn't show OK in your calendar (white background with white font). So the birthday must have a good visible color, which sadly isn't yellow.

@czernedo
Copy link

+1!
Especially when using Today Calendar on Android it's annoying because there is white Font on Yellow ground then. :/

@jancborchardt
Copy link
Member

Good point by @MariusBluem, so it should be black on white by default? Or can you show a screenshot of how macOS does it?

@MariusBluem
Copy link
Member

img_4923

@jancborchardt

@ghost
Copy link

ghost commented Aug 14, 2017

I have to install Calendar Color ( https://github.com/pascalfree/calendar-color/releases ) just to change this single birthday calendar colour. I would really appreciate if we could change it ourselves on Nextcloud.

@jancborchardt
Copy link
Member

@georgehrke @tcitworld @Henni @irgendwie can we change this? :) It's a papercut.

@georgehrke
Copy link
Member

georgehrke commented Aug 14, 2017 via email

@tcitworld
Copy link
Member

That's what I thought as well, but this doesn't look like it's fixed yet.

@jancborchardt
Copy link
Member

Let’s simply set another default color for the birthday calendar. For example the rightmost (pink) one, cause that is the last which will be used on creating new calendars.

@Peque
Copy link
Contributor

Peque commented Aug 14, 2017

@jancborchardt With "will be used" you mean "will be chosen by the user"? I think that is pretty subjective. Also, if that is true, then the fact that people chose it less often probably means they dislike it or they find it uglier, so why would they want an ugly color for their birthday calendar?

I think the problem is not being able to change the color at will, rather than the particular default color.

@jancborchardt
Copy link
Member

The main issue is the default color not being readable, as written in the original issue. Most people don't change the default so our primary goal should be sane defaults.

By "will be used" I mean that new Calendars you create automatically use the next not-yet-used color from the color list from left to right (at least should be @georgehrke @tcitworld) - hence the rightmost color would be used last by this automatic algorithm.

@Peque
Copy link
Contributor

Peque commented Aug 15, 2017

@jancborchardt Understood, thanks. Would it make sense to split this issue into two? (i.e.: "Better default birthday calendar color" and "Allow changing the birthday calendar color")

I, for instance, am interested in the latter feature, rather than the discussion about the defaults, and the original issue (as well as the referenced nextcloud/calendar#274) both talk about a color picker for the birthday calendar.

@jancborchardt
Copy link
Member

Yes, they are different issues. This one is about the default. :)

@georgehrke
Copy link
Member

Please wait with creating a new issue about changing it.
I will first verify if not being able to change it is a server or a client issue

@pengandy
Copy link

Hi @georgehrke, do you have news on that? I experience the same on my Android phone: light yellow color is picked by the calendar app with white font. So it is impossible to read any birthday event. I think it isn't a coincidence that the mobile app picks the same color like within the nextcloud birthday calendar.

This issue is now open for 8 month and it's not really a corner case. Would be great if you could follow that up. Thx Andy

@j-ed
Copy link
Contributor

j-ed commented Sep 19, 2017

At least with Nextcloud 12.0.2 and the Calendar app 1.5.4 it is still not possible to change the color of the birthday calendar.

Beside the discussion if this feature should be implemented or not, I want to point your attention on the fact that many people with handicaps exist who cannot differentiate pastel colors very well. Therefore I would appreciate the possibility to adjust the colors individually.

@jancborchardt jancborchardt added bug design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. and removed enhancement labels Sep 21, 2017
@Peque
Copy link
Contributor

Peque commented Sep 27, 2017

@georgehrke Did you verify it?

@georgehrke
Copy link
Member

[georgehrke@... (11:02:22) ~] curl 'http://nextcloud.dev/remote.php/dav/calendars/admin/contact_birthdays/' -X PROPPATCH --user admin:admin --data-binary '<d:propertyupdate xmlns:d="DAV:"><d:set><d:prop><a:calendar-color xmlns:a="http://apple.com/ns/ical/">#74cce7</a:calendar-color></d:prop></d:set></d:propertyupdate>'
<?xml version="1.0"?>
<d:multistatus xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns" xmlns:cal="urn:ietf:params:xml:ns:caldav" xmlns:cs="http://calendarserver.org/ns/" xmlns:card="urn:ietf:params:xml:ns:carddav" xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns"><d:response><d:href>/remote.php/dav/calendars/admin/contact_birthdays</d:href><d:propstat><d:prop><x1:calendar-color xmlns:x1="http://apple.com/ns/ical/"/></d:prop><d:status>HTTP/1.1 200 OK</d:status></d:propstat></d:response></d:multistatus>

Sending a prop patch works => most likely a calendar app issue

@georgehrke
Copy link
Member

georgehrke commented Sep 27, 2017

Like @MariusBluem, I would also suggest changing the default color to white and prepending 🎂 to the events name.

(We will have to omit the 🎂 on databases when mb4 is not supported)

Let's do it?

@tcitworld
Copy link
Member

How would we know the calendar is activated or not in the calendar app if we don't have any events to display ?

@Peque
Copy link
Contributor

Peque commented Sep 27, 2017

@georgehrke Could you reopen nextcloud/calendar#313 then?

@juliusknorr
Copy link
Member

Changing the color though caldav works. So the rest of the implementation needs to be done on the calendar app: nextcloud/calendar#313

@monreal
Copy link
Contributor

monreal commented Apr 26, 2018

@juliushaertl which app can change the color through CalDAV? Neither my GNOME Calendar nor Simple Calendar on Android can :/

@juliusknorr
Copy link
Member

@monreal I actually just used curl for it:

curl 'https://cloud.example.com/remote.php/dav/calendars/admin/contact_birthdays/' -X PROPPATCH --user admin:password --data-binary '<d:propertyupdate xmlns:d="DAV:"><d:set><d:prop><a:calendar-color xmlns:a="http://apple.com/ns/ical/">#eeeeee</a:calendar-color></d:prop></d:set></d:propertyupdate>

@monreal
Copy link
Contributor

monreal commented Apr 27, 2018

@juliushaertl works great, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

No branches or pull requests