On the screenshot the new accent color is nearly not visible in contrast to the surroundings espwcially in dark mode. Can we add a bit more contrast there?

[szaimen]

On the screenshot the new accent color is nearly not visible in contrast to the surroundings espwcially in dark mode. Can we add a bit more contrast there?

We're back on the previous values, please raise the issue to the design team 😉

Cc @jancborchardt @nimishavijay

Originally posted by @szaimen in #32146 (comment)

[szaimen]

It is about these screenshots: #32146 (comment)

[jancborchardt]

Yeah, probably makes sense to increase the primary-light from 10% to 15% or something like that in dark mode, as visually it’s different on dark than on light. @skjnldsv?

[skjnldsv]

@jancborchardt please do so and tell us which value you prefer :)

server/apps/theming/lib/Themes/DefaultTheme.php

Line 112 in dffbddc

'--color-primary-light' => $this->util->mix($this->primaryColor, $colorMainBackground, -80),

server/apps/theming/lib/Themes/DarkTheme.php

Line 73 in dffbddc

'--color-primary-light' => $this->util->mix($this->primaryColor, $colorMainBackground, -80),

[szaimen]

@jancborchardt any update here?

[skjnldsv]

We fixed a few values btw, not sure this is still needed. There was some errors in the first PR! 🤔

[szaimen]

Let me test this tomorrow...

[szaimen]

Screenshots from the PR:

Before	After

My test from today:

light	dark

[szaimen]

So it seems like the the color of the bright mode wasn't correct in the initial PR. However I still think the contrast of the color isn't as good as it should be.

@jancborchardt WDYT?

[szaimen]

Seems like we need to rework this anywhay due to accessibility issues? Cc @jancborchardt