-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BITV] 9.4.1.2/3.10 - The "Details" section contains a tab list that has not been implemented correctly. (2) #37107
Comments
The current implementation Will changing |
I don't see an advantage in using an unordered list here. A proper implementation should look like the example at https://www.w3.org/WAI/ARIA/apg/patterns/tabs/examples/tabs-automatic/. I've examined the current implementation at https://try.nextcloud.com/ltd/a11y/index.php/apps/files/?dir=/&fileid=677 using VoiceOver, and it seems to work correctly. However, I don't understand why there's a radio button inside the element with role="tab". In theory, this could lead to issues. As I mentioned before, you can find a correctly functioning example at the URL above. |
Understood 👍 Would making the input |
From my perspective, it's irrelevant in this case, as shown in the example the native role is overridden by the role="tab".
|
Is the tablist implementation on https://try.nextcloud.com/ltd/a11y/ accessible @michaelnissenbaum ? |
From my perspective, the implementation of the tab bar is still not 100% accessible. The use of button elements (type="button") nested within "span" elements with the role "tab" results in being able to access the individual tabs one by one using the TAB key. Depending on the screen reader, they may not be identified as tabs but rather as buttons. Additionally, navigation through the tabs should only be possible using arrow keys. Even when using Chromium-based browsers, both the "tab" and "group" roles are announced in the reading mode. Here's another example for reference: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/Tab_Role. |
It is recommended to set the role="tablist" on the ul element and remove the nav element.
Details
https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-bfbf07e5c3-v3-n10
The text was updated successfully, but these errors were encountered: