Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent continuous file-reading when stopping/restarting streaming triggered by in-video searches #40107

Closed
AndyScherzinger opened this issue Aug 29, 2023 · 0 comments

Comments

@AndyScherzinger
Copy link
Member

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.

  • Share a big video by link, in my test I use a 6GB mp4 video
  • Open the link in the browser, I use FireFox
  • Open the network tab of the browser to watch networking activity
  • Start top on the server to watch apache processes and server load
  • Start playing the video, then slowly pull the seek handle to the right
  • This produces lots of range requests and the same amount of apache processes serving one request each
  • If the serving processes don't monitor connection status then all of them read the video from the start point requested in the range request to the end of the file, producing a lot of load on the server.
  • The problem is worse if the client is on a relatively slow DSL connection

Describe the solution you'd like
Opening such a link, playing the video directly in the browser and then seeking in the video produces (lots of) range requests for the video file. This is okay, as the browser closes all the connections for range requests it is no longer interested in. But PHP does not care and the way the video was served resulted in all the requests reading the video to the end, producing a lot of load on the storage system and on the server itself for no good reason. Prevent this problem by checking connection status regularly.

Describe alternatives you've considered
none

Additional context
none

@AndyScherzinger AndyScherzinger added bug enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Aug 29, 2023
@AndyScherzinger AndyScherzinger added this to the Nextcloud 25.0.11 milestone Aug 29, 2023
@AndyScherzinger AndyScherzinger moved this to 📄 To do (~10 entries) in 📁 Files team Aug 29, 2023
@come-nc come-nc moved this from 📄 To do (~10 entries) to 🏗️ In progress in 📁 Files team Sep 4, 2023
@come-nc come-nc added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Sep 4, 2023
@AndyScherzinger AndyScherzinger moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants