Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV]: Make selected background button visible for assistive technologies #40686

Closed
JuliaKirschenheuter opened this issue Sep 28, 2023 · 0 comments · Fixed by #40950
Closed

[BITV]: Make selected background button visible for assistive technologies #40686

JuliaKirschenheuter opened this issue Sep 28, 2023 · 0 comments · Fixed by #40950
Assignees
@susnux
Labels
3. to review Waiting for reviews accessibility enhancement
Milestone
Nextcloud 28

Comments

@JuliaKirschenheuter
Copy link
Contributor

This is accessibility issue.

image

For now there is only visual selection of chosen background button. There have to be some identification for assistive technologies. There are different ways:

  1. Add "activated" word to aria-label as far button is activated
  2. Use aria-pressed="true" state as far button is activated
@JuliaKirschenheuter JuliaKirschenheuter added enhancement 1. to develop Accepted and waiting to be taken care of accessibility labels Sep 28, 2023
@susnux susnux self-assigned this Oct 2, 2023
@susnux susnux added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Oct 17, 2023
@susnux susnux mentioned this issue Oct 17, 2023
Merged
4 tasks
@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@susnux susnux

Labels
3. to review Waiting for reviews accessibility enhancement
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging a pull request may close this issue.

fix(theming): Add aria-pressed attribute to active background nextcloud/server
3 participants
@AndyScherzinger @susnux @JuliaKirschenheuter