Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV]: Sharing tab: sticky buttons "update share" and "cancel" overlapping important interactive content #41304

Closed
JuliaKirschenheuter opened this issue Nov 6, 2023 · 8 comments · Fixed by #41444
Assignees
Labels
1. to develop Accepted and waiting to be taken care of enhancement
Milestone

Comments

@JuliaKirschenheuter
Copy link
Contributor

That should not be a case ;(

Peek 2023-11-06 14-32

@nimishavijay @marcoambrosini how could we solve a problem?

@JuliaKirschenheuter JuliaKirschenheuter added enhancement 1. to develop Accepted and waiting to be taken care of labels Nov 6, 2023
@nimishavijay
Copy link
Member

It is useful to not have to scroll all the way to the bottom to save our share settings, so I would vote for it to remain sticky. Would it be better if we added a background behind the buttons?

@marcoambrosini
Copy link
Member

The buttons container needs to be below the scrolling container. So not position: sticky really just another block. I think flex layout column would be the best.

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Nov 9, 2023
@JuliaKirschenheuter
Copy link
Contributor Author

Dear @michaelnissenbaum

would it be ok if there would be a white (or dark) background behind this 2 buttons? Then buttons won't overlap each other directly. Thank you!

@michaelnissenbaum
Copy link

michaelnissenbaum commented Nov 12, 2023

Hi @JuliaKirschenheuter. Changing the background for the two buttons does not solve the problem we have. The two buttons overlap important content and functions behind them, forcing users to scroll constantly to access the content behind these buttons. I would suggest that the container with the two buttons starts where the container with other elements that need to be scrolled ends.

@jancborchardt
Copy link
Member

I would suggest that the container with the two buttons starts where the container with other elements that need to be scrolled ends.

@michaelnissenbaum our concern was that in this case people might not discover the very important confirmation action button on the bottom as it might be outside of the viewport and needs to be scrolled to. And the confirmation action is always important, whereas the content further down in the share tab gets decreasingly important in comparison.

@marcoambrosini
Copy link
Member

I think @michaelnissenbaum and I are saying the same thing. @michaelnissenbaum do you mean this?

Screenshot 2023-11-13 at 21 32 00

@JuliaKirschenheuter
Copy link
Contributor Author

Hi @michaelnissenbaum,

Thank you!
The possible solution could be only:

Peek 2023-11-13 13-38

Would that be ok?

@michaelnissenbaum
Copy link

Hi @JuliaKirschenheuter. The solution is OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement
Projects
None yet
6 participants