Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Move or copy file on link share does not work #42009

Closed
5 of 8 tasks
Tracked by #3888
andrey18106 opened this issue Dec 4, 2023 · 10 comments · Fixed by nextcloud-libraries/nextcloud-dialogs#1241, #43765 or #45538
Closed
5 of 8 tasks
Tracked by #3888
Assignees
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 27-feedback bug feature: files feature: sharing regression

Comments

@andrey18106
Copy link
Contributor

⚠️ This issue respects the following points: ⚠️

Bug description

There is a bug when you're trying to move files inside of a full access link share. The modal "Choose target files" not getting directory listing for move or copy target, because the userid and path for DAV request is missing in the context of link share.

Steps to reproduce

  1. Create directory d1
  2. Create directory d2 inside of d1
  3. Create file f1.txt inside of d1
  4. Create link share of d1 with full access (Can edit)
  5. Open link share in other browser (does not matter if you are being logged in to Nextcloud)
  6. Select f1.txt
  7. Try to move f1.txt into d2 via actions -> move or copy
  8. See error: "Choose target folder" modal list is not loading

Expected behavior

The files in "Choose target folder" modal displayed correctly with only shared items to perform operations allowed with "Full access link share", and these operations are successfully made.

Installation method

None

Nextcloud Server version

27

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.1

Web server

Apache (supported)

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

Fresh Nextcloud Server install

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

From browser console:

`PROPFIND https://stable27.local/remote.php/dav/files/undefined/`

Additional info

image

@andrey18106 andrey18106 added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Dec 4, 2023
@szaimen
Copy link
Contributor

szaimen commented Dec 4, 2023

Cc @susnux

@paulijar
Copy link
Contributor

paulijar commented Dec 10, 2023

I see a similar problem on all the file dialogs launched by the Music app on NC28.0.0 RC4 (and also RC2). On NC 27.1.2, these dialogs worked fine. Is the legacy wrapper for the file dialogs broken again?

@susnux
Copy link
Contributor

susnux commented Dec 14, 2023

I see a similar problem on all the file dialogs launched by the Music app on NC28.0.0 RC4 (and also RC2). On NC 27.1.2, these dialogs worked fine.

Sounds unrelated, this one is caused by the wrong endpoint (webdav vs dav) because of anonymous users. This did not even work with 27.1.x.
So @paulijar feel free to report a separate issue for that one with some information about it (browser console errors?).

@susnux
Copy link
Contributor

susnux commented Dec 14, 2023

Cc susnux

I can have a look on this one.

@susnux susnux self-assigned this Dec 14, 2023
@susnux susnux added this to the Nextcloud 27.1.6 milestone Dec 14, 2023
@susnux susnux moved this to 📄 To do (~10 entries) in 📁 Files team Dec 14, 2023
@paulijar
Copy link
Contributor

@susnux Okay, thanks for the info. I now created the report #42291.

@timm2k
Copy link
Contributor

timm2k commented Jan 18, 2024

Any news on this?

@andrey18106
Copy link
Contributor Author

@susnux is there any update on this?

@timm2k
Copy link
Contributor

timm2k commented Feb 7, 2024

Also Nextcloud 28.0.2 is showing same error

[...]/remote.php/dav/files/undefined/ 401 (Unauthorized)

@ShGKme
Copy link
Contributor

ShGKme commented May 27, 2024

Issue is still reproducible on master (Nextcloud 30)

@ShGKme ShGKme reopened this May 27, 2024
@github-project-automation github-project-automation bot moved this from ☑️ Done to 📄 To do (~10 entries) in 📁 Files team May 27, 2024
@susnux
Copy link
Contributor

susnux commented May 27, 2024

Issue is still reproducible on master (Nextcloud 30)

Unrelated / other issue that caused this. The current issue is a regression in the files library and already fixed with:
nextcloud-libraries/nextcloud-files#959

@susnux susnux closed this as completed May 27, 2024
@github-project-automation github-project-automation bot moved this from 📄 To do (~10 entries) to ☑️ Done in 📁 Files team May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment