Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV]: Replace <h2> element from 'Users' view to span #42554

Closed
emoral435 opened this issue Jan 2, 2024 · 2 comments · Fixed by nextcloud-libraries/nextcloud-vue#5020
Closed

[BITV]: Replace <h2> element from 'Users' view to span #42554

emoral435 opened this issue Jan 2, 2024 · 2 comments · Fixed by nextcloud-libraries/nextcloud-vue#5020
Assignees
@emoral435
Labels
2. developing Work in progress accessibility dependencies enhancement

Comments

@emoral435
Copy link
Contributor

This issue messes up the the Heading hierarchic within the view of the 'Users' view. This is due to a NcVue component, so we will need to get this in the next NcVue package update before the next review

Image for example

Image
@emoral435 emoral435 self-assigned this Jan 2, 2024
@emoral435 emoral435 mentioned this issue Jan 2, 2024
Merged
2 tasks
@szaimen
Copy link
Contributor

szaimen commented Jan 26, 2024

dependency update in stable28 is missing

@szaimen szaimen reopened this Jan 26, 2024
@emoral435
Copy link
Contributor Author

Will be good to check again once #43064 gets merged!

@emoral435 emoral435 changed the title Replace <h2> element from 'Users' view to span [BITV]: Replace <h2> element from 'Users' view to span Jan 31, 2024
@szaimen szaimen closed this as completed Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emoral435 emoral435

Labels
2. developing Work in progress accessibility dependencies enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(NcAppNavigation): change h2 to span nextcloud-libraries/nextcloud-vue
3 participants
@JuliaKirschenheuter @szaimen @emoral435