Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: File sorting based on numbers (with points ) changed in NC 28 #42826

Closed
6 of 8 tasks
ONP-ISI opened this issue Jan 16, 2024 · 15 comments · Fixed by #45419
Closed
6 of 8 tasks

[Bug]: File sorting based on numbers (with points ) changed in NC 28 #42826

ONP-ISI opened this issue Jan 16, 2024 · 15 comments · Fixed by #45419
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 28-feedback bug feature: files

Comments

@ONP-ISI
Copy link

ONP-ISI commented Jan 16, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

File sorting based on numbers with points ( YYYY.MM.DD ) has changed in 28.0.1. No problem is 27.1.5
For example, with 3 folders named 2023.01.08, 2023.04.09, 2023.10.12, if I to do descending sort order or ascending, 2023.01.08 will be in the middle, not at the beginning or the end.
If you replace points with hyphens (2023-01-08, 2023-04-09, 2023-10-12), 2023-01-08 will be at beginning or at the end.

Steps to reproduce

1.Create 3 folder named 2023.01.08, 2023.04.09, 2023.10.12
2.Clich on file sort by name
3.

Expected behavior

NOK : Descending sort order or ascending, 2023.01.08 will be in the middle, not at the beginning or the end.
OK : Replace points with hyphens (2023-01-08, 2023-04-09, 2023-10-12), 2023-01-08 will be at beginning or at the end.

Installation method

Community Manual installation with Archive

Nextcloud Server version

28

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version (ex. 22 to 23)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "192.168.XXX.XXX",
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "28.0.1.1",
        "overwrite.cli.url": "https:\/\/XXX.XXX.XXX.fr\/nextcloud",
        "overwritehost": "XXX.XXX.XXX.fr",
        "overwriteprotocol": "https",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "default_phone_region": "FR",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "memcache.local": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 6379
        },
        "maintenance": false,
        "theme": "",
        "loglevel": 2,
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "25",
        "mail_sendmailmode": "smtp",
        "default_language": "fr",
        "default_locale": "fr_FR",
        "skeletondirectory": "",
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "ldapProviderFactory": "OCA\\User_LDAP\\LDAPProviderFactory",
        "user_email_visible": "true"
    }
}

List of activated Apps

Enabled:
  - activity: 2.20.0
  - circles: 28.0.0-dev
  - cloud_federation_api: 1.11.0
  - dav: 1.29.1
  - federatedfilesharing: 1.18.0
  - federation: 1.18.0
  - files: 2.0.0
  - files_accesscontrol: 1.18.0
  - files_pdfviewer: 2.9.0
  - files_reminders: 1.1.0
  - files_sharing: 1.20.0
  - files_trashbin: 1.18.0
  - files_versions: 1.21.0
  - groupfolders: 16.0.2
  - logreader: 2.13.0
  - lookup_server_connector: 1.16.0
  - notifications: 2.16.0
  - oauth2: 1.16.3
  - password_policy: 1.18.0
  - privacy: 1.12.0
  - provisioning_api: 1.18.0
  - quota_warning: 1.18.0
  - recommendations: 2.0.0
  - related_resources: 1.3.0
  - serverinfo: 1.18.0
  - settings: 1.10.1
  - sharebymail: 1.18.0
  - systemtags: 1.18.0
  - theming: 2.3.0
  - twofactor_backupcodes: 1.17.0
  - updatenotification: 1.18.0
  - user_ldap: 1.19.0
  - viewer: 2.2.0
  - workflowengine: 2.10.0
Disabled:
  - admin_audit: 1.18.0
  - bruteforcesettings: 2.8.0 (installed 2.4.0)
  - comments: 1.18.0 (installed 1.10.0)
  - contactsinteraction: 1.9.0 (installed 1.1.0)
  - dashboard: 7.8.0 (installed 7.0.0)
  - encryption: 2.16.0
  - files_antivirus: 5.4.0 (installed 5.4.0)
  - files_automatedtagging: 1.18.0 (installed 1.18.0)
  - files_downloadactivity: 1.16.0 (installed 1.16.0)
  - files_external: 1.20.0
  - files_retention: 1.16.0 (installed 1.16.0)
  - files_rightclick: 0.15.1 (installed 1.6.0)
  - files_trackdownloads: 1.11.0 (installed 1.11.0)
  - firstrunwizard: 2.17.0 (installed 2.9.0)
  - nextcloud_announcements: 1.17.0 (installed 1.9.0)
  - photos: 2.4.0 (installed 1.1.0)
  - ransomware_protection: 1.14.0 (installed 1.14.0)
  - sharelisting: 1.2.0 (installed 1.2.0)
  - side_menu: 3.11.2 (installed 3.11.2)
  - support: 1.11.0 (installed 1.3.0)
  - survey_client: 1.16.0 (installed 1.8.0)
  - suspicious_login: 6.0.0
  - text: 3.9.1 (installed 3.1.0)
  - twofactor_totp: 10.0.0-beta.2
  - user_status: 1.8.1 (installed 1.0.1)
  - weather_status: 1.8.0 (installed 1.0.0)

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

No response

Additional info

No response

@ONP-ISI ONP-ISI added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Jan 16, 2024
@ONP-ISI
Copy link
Author

ONP-ISI commented Jan 16, 2024

@ONP-ISI ONP-ISI changed the title [Bug]: [Bug]: File sorting based on numbers (with points ) changed in NC 28 Jan 16, 2024
@jop217
Copy link

jop217 commented Feb 6, 2024

Same here. Very frustrating for large folders

@v3DJG6GL
Copy link

v3DJG6GL commented Mar 7, 2024

The same goes for me, it's very annoying to have dozens of folders with this naming structure:
Screenshot 2024-03-07 at 18-33-32

@szaimen
Copy link
Contributor

szaimen commented Mar 7, 2024

Cc @nextcloud/server-frontend

@visit1985
Copy link

I have a similar issue with slightly different pattern.

Sorting by Name descending in NC 28:
Screenshot 2024-05-05 at 14 22 36

This may have the same root cause.

@v3DJG6GL
Copy link

v3DJG6GL commented May 6, 2024

@szaimen
This issue is still present with Nextcloud 29.0.0. Hopefully it will be addressed soon...

@autoantwort
Copy link

I don't know if I should create a separate bug report for it, but the files are in the right order for me, but when I open the preview the order is not correct.

Screen.Recording.2024-05-13.at.14.19.24.mov

@DevMichaelSabo
Copy link

The 29.0.1 doesn't fix the problem in https://help.nextcloud.com/t/sorting-doesnt-working/190105!

@susnux
Copy link
Contributor

susnux commented Jun 1, 2024

You can see from the milestone of the merged PR that the fix will only be available in Nextcloud 29.0.2+ (and 28.0.7+).

@nightcore500
Copy link

As @autoantwort already mentioned, this sorting problem exists not only in the folder listing in the file browser but also in the file preview.
I am now on release 29.0.2 and unfortunately still have the problem that when scrolling through the images in the file preview, the images are displayed completely mixed up. However, the files are displayed correctly in the file browser according to the timestamp in the file name.

Filebrowser:
filebrowser Screenshot 2024-06-06 144214

First file:
first Screenshot 2024-06-06 144226

Next file:
after Screenshot 2024-06-06 144234

@susnux
Copy link
Contributor

susnux commented Jun 7, 2024

I am now on release 29.0.2 and unfortunately still have the problem that when scrolling through the images in the file preview, the images are displayed completely mixed up.

@nightcore500 you screenshot is lacking the table headers, from the content it seems like you are sorting by date not name?

@nightcore500
Copy link

@susnux That is correct. The folder is sorted by date. In the folder view, it is sorted correctly as shown in the screenshot. After IMG20240605 comes IMG20240604. In the preview, however, IMG20240403 suddenly appears after IMG20240605, which is far in the past. I have just sorted by name. It then no longer seems to occur.

@susnux
Copy link
Contributor

susnux commented Jun 7, 2024

Yes if you sort by "Modified" then the mtime of the files is checked not the filename, if you sort by "Name" then the filename is taken into account.

@nightcore500
Copy link

@susnux Thank you for your help. But after IMG20240605 the file named IMG20240403 is displayed whose mtime does not come after that of IMG20240605. The files are also sorted correctly by mtime in the file browser. IMG20240403 also correctly appears there much later. But not in the preview?

@susnux
Copy link
Contributor

susnux commented Jun 11, 2024

I am not sure if I understand you here correctly, this issue is just about the files list.
If you sort by "Name" then only the name is considered, if you sort by "Modified" then only the mtime (the filename is ignored).

If you have issues with the "viewer" (that one that opens if you click on a file), then this is a different issue and should be reported here:

https://github.com/nextcloud/viewer/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 28-feedback bug feature: files
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants