Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a notice for instant upload / drag&drop in below file list #4483

Closed
eppfel opened this issue Apr 25, 2017 · 16 comments · Fixed by #40674
Closed

Introduce a notice for instant upload / drag&drop in below file list #4483

eppfel opened this issue Apr 25, 2017 · 16 comments · Fixed by #40674
Assignees
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement feature: files good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.

Comments

@eppfel
Copy link
Member

eppfel commented Apr 25, 2017

As discussed in #4273 we want to break down @Espina2 ideas into smaller improvements. I propose to introduce the notice for drag & drop in the whitespace below the files. This is in particular helpful in public sharing / to non-nextcloud users.

Here is a quick sketch:
files-drag drop

If the file list takes the whole height, the info could move directly above the first file as in @Espina2 proposal.

@nextcloud/designers

@eppfel eppfel added 0. Needs triage Pending check for reproducibility or if it fits our roadmap design Design, UI, UX, etc. enhancement feature: files labels Apr 25, 2017
@Espina2
Copy link
Contributor

Espina2 commented Apr 25, 2017

@eppfel This will break as soon as you have more projects or a smaller resolution.

@MorrisJobke
Copy link
Member

I would also say, that it should be on the top and you should be able to remove it (setting a cookie for external users and a setting for internal ones). Just 2 rows at the top that say the same.

@jancborchardt
Copy link
Member

@Espina2 as @eppfel said above:

If the file list takes the whole height, the info could move directly above the first file as in @Espina2 proposal.

I do agree though that it should be on the top of the file list, maximum 2 rows height, and with an x-Close button. Then it’s always in the same place and doesn’t depend on the size of the view.

Great work! :)

@Espina2
Copy link
Contributor

Espina2 commented Apr 25, 2017

Also agree with the close button.

@eppfel eppfel added 1. to develop Accepted and waiting to be taken care of papercut Annoying recurring issue with possibly simple fix. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Apr 26, 2017
@jancborchardt
Copy link
Member

As @eppfel suggested in #4011 (comment) we should do this as the first row of the files view, combined with the Upload function. (That is, clicking on it will open the dropdown with the filetypes.)

Wording could be:

Choose files to upload or drag & drop

Maybe a bit shorter, but also we should include that you can create folders via that function. Maybe it even makes sense to directly show the most important functions like Upload file, New folder, and then a 3-dot menu for the rest? (Text files and Collabora filetypes)

@Espina2
Copy link
Contributor

Espina2 commented May 20, 2017

@jancborchardt

Upload file, New folder, and then a 3-dot menu for the rest?

Please don't do that, one of the problems that the actual UI have is important stuff hide on the three dots.

@jancborchardt
Copy link
Member

@Espina2 if everything is important, nothing is important. There has to be some prioritization. And we have adding options for Spreadsheets, Documents, Presentation etc - no way we show that all in the UI without it being cluttered.

@skjnldsv
Copy link
Member

skjnldsv commented Mar 1, 2018

Should the close button move it at the end of the file list?
Should we memorise the setting so if we refresh the drop is still gone?
There was an app by @rullzer and @tobiasKaminsky where the drop was in the left sidebar. https://github.com/rullzer/dropit

Since dropping on low screen is anyway almost impossible, we could either:

  1. Only have a drop on the left bottom (above the settings)
  2. Have it above the file list and move it in the sidebar on close

@rullzer
Copy link
Member

rullzer commented Mar 2, 2018

@skjnldsv there is no drop on the left in dropit. There is just the link to it there ;)

@skjnldsv
Copy link
Member

skjnldsv commented Mar 2, 2018

@rullzer oh? I misunderstood, I thought you added a drop zone :)

@rullzer
Copy link
Member

rullzer commented Mar 2, 2018

Yeah that was the plan. But my js fu failed me

@MorrisJobke
Copy link
Member

This is also more about dropping in the current folder. You can also drop onto the files list: if it is a folder it is highlighted and you drop into it or if it is a file it will highlight the whole file list (IIRC) and then uploads in the current folder

@MorrisJobke
Copy link
Member

Also the setting should be remembered- one per user - and the notice is then completely gone and not I. The bottom, or?

@skjnldsv
Copy link
Member

skjnldsv commented Mar 4, 2018

To my view, the drop zone should not be gone completely. If the user closes it, we should ensure that if he wants it back, he should do it without too much difficulties :)
Nonetheless, couldn't we just set the whole blank area at the bottom as a drop zone?

@MorrisJobke
Copy link
Member

Nonetheless, couldn't we just set the whole blank area at the bottom as a drop zone?

But the whole app content (not the sidebars) is already a drop zone 🤔 What do you want to add here? This ticket is only about a little help text to make it more obvious.

@skjnldsv
Copy link
Member

skjnldsv commented Mar 5, 2018

What do you want to add here?

Just a more obvious text/div/whatever to be more noticeable :)

@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 20, 2018
@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Oct 1, 2018
@jancborchardt jancborchardt added this to the Nextcloud 18 milestone Mar 13, 2019
@rullzer rullzer removed this from the Nextcloud 18 milestone Dec 9, 2019
@skjnldsv skjnldsv removed their assignment Jul 5, 2021
@skjnldsv skjnldsv added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Sep 27, 2023
@skjnldsv skjnldsv self-assigned this Sep 27, 2023
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 28, 2023
@skjnldsv skjnldsv moved this to Done in Files to vue Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement feature: files good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants