Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Comment is added to the wrong file when not explicitly closing file details #45488

Closed
5 of 8 tasks
Gielovic opened this issue May 23, 2024 · 2 comments
Closed
5 of 8 tasks
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 28-feedback bug feature: comments feature: files

Comments

@Gielovic
Copy link

⚠️ This issue respects the following points: ⚠️

Bug description

The comments I'm adding to a file or folder keep ending up at the wrong file or folder. When opening details of a file or folder and writing a comment with an at-mention, after hitting enter, the comment does not show. The activity stream tells it is placed at some other file or folder (that was opened before).

Redoing the steps do place the comment at the correct location.
I guess, the wrong file-id (from a previous navigation action) is used, instead that of the current opened file details.
After closing the file-details, reopening it, and adding the comment again, it shows up at the correct file's comment thread.

Steps to reproduce

  1. Open a folders/files details
  2. navigate through the file tree (keep details of former file open)
  3. Open details of another file
  4. Start typing and use an at-mention
  5. XHR query uses id of former file (step1 )

This continues till you:

  1. close details view by pressing x
  2. open details of yet another file.

Expected behavior

Obviously, a comment should be post at the file/folder that is currently showing in the details screen.

Installation method

Community Docker image

Nextcloud Server version

28

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Updated from a MINOR version (ex. 22.1 to 22.2)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
    "system": {
        "htaccess.RewriteBase": "\/",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "apps_paths": [
            {
                "path": "\/var\/www\/html\/apps",
                "url": "\/apps",
                "writable": false
            },
            {
                "path": "\/var\/www\/html\/custom_apps",
                "url": "\/custom_apps",
                "writable": true
            }
        ],
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "***REMOVED SENSITIVE VALUE***",
            "***REMOVED SENSITIVE VALUE***",
            "***REMOVED SENSITIVE VALUE***"
        ],
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "overwrite.cli.url": "https:\/\/***REMOVED SENSITIVE VALUE***",
        "overwriteprotocol": "https",
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "28.0.5.1",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "mail_smtpmode": "smtp",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "twofactor_enforced": "true",
        "twofactor_enforced_groups": [
            "bestuur",
            "admin"
        ],
        "twofactor_enforced_excluded_groups": [
            "device"
        ],
        "maintenance": false,
        "theme": "",
        "loglevel": 2,
        "filelocking.enable": true,
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "mail_smtpauth": 1,
        "mail_smtpauthtype": "LOGIN",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "mail_smtptimeout": 30,
        "mail_smtpdebug": true,
        "mail_smtpport": "587",
        "mail_sendmailmode": "smtp",
        "allow_local_remote_servers": true,
        "enabledPreviewProviders": [
            "OC\\Preview\\PNG",
            "OC\\Preview\\JPEG",
            "OC\\Preview\\GIF",
            "OC\\Preview\\HEIC",
            "OC\\Preview\\BMP",
            "OC\\Preview\\XBitmap",
            "OC\\Preview\\MP3",
            "OC\\Preview\\MarkDown",
            "OC\\Preview\\OpenDocument",
            "OC\\Preview\\Krita"
        ],
        "app_install_overwrite": [
            "duplicatefinder"
        ],
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "password": "***REMOVED SENSITIVE VALUE***",
            "port": 6379
        },
        "updater.release.channel": "stable",
        "maintenance_window_start": 1,
        "updater.secret": "***REMOVED SENSITIVE VALUE***"
    }
}

List of activated Apps

Enabled:
  - activity: 2.20.0
  - admin_audit: 1.18.0
  - announcementcenter: 6.8.1
  - approval: 1.2.0
  - assistant: 1.0.9
  - bruteforcesettings: 2.8.0
  - calendar: 4.7.4
  - circles: 28.0.0
  - cloud_federation_api: 1.11.0
  - collectives: 2.11.0
  - comments: 1.18.0
  - contacts: 5.5.3
  - dashboard: 7.8.0
  - dav: 1.29.1
  - deck: 1.12.2
  - external: 5.3.1
  - federatedfilesharing: 1.18.0
  - files: 2.0.0
  - files_accesscontrol: 1.18.1
  - files_automatedtagging: 1.18.0
  - files_external: 1.20.0
  - files_pdfviewer: 2.9.0
  - files_reminders: 1.1.0
  - files_retention: 1.17.2
  - files_sharing: 1.20.0
  - files_trashbin: 1.18.0
  - files_versions: 1.21.0
  - firstrunwizard: 2.17.0
  - flow_notifications: 1.8.0
  - forms: 4.2.3
  - groupfolders: 16.0.6
  - integration_gitlab: 1.0.19
  - integration_zammad: 2.0.7
  - llm: 1.2.1
  - logreader: 2.13.0
  - lookup_server_connector: 1.16.0
  - nextcloud_announcements: 1.17.0
  - notes: 4.10.0
  - notifications: 2.16.0
  - oauth2: 1.16.3
  - password_policy: 1.18.0
  - privacy: 1.12.0
  - provisioning_api: 1.18.0
  - recommendations: 2.0.0
  - related_resources: 1.3.0
  - richdocuments: 8.3.7
  - serverinfo: 1.18.0
  - settings: 1.10.1
  - sharebymail: 1.18.0
  - sociallogin: 5.6.4
  - spreed: 18.0.8
  - systemtags: 1.18.0
  - tables: 0.7.2
  - tasks: 0.16.0
  - text: 3.9.1
  - theming: 2.3.0
  - timemanager: 0.3.14
  - twofactor_backupcodes: 1.17.0
  - twofactor_totp: 10.0.0-beta.2
  - updatenotification: 1.18.0
  - user_status: 1.8.1
  - viewer: 2.2.0
  - workflow_pdf_converter: 1.13.0
  - workflowengine: 2.10.0
Disabled:
  - breezedark: 28.0.0 (installed 28.0.0)
  - contactsinteraction: 1.9.0 (installed 1.8.0)
  - encryption: 2.16.0
  - federation: 1.18.0 (installed 1.10.1)
  - integration_openproject: 2.6.3 (installed 2.6.3)
  - inventory: 0.1.2 (installed 0.1.2)
  - mail: 3.6.1 (installed 3.6.1)
  - maps: 1.4.0 (installed 1.4.0)
  - photos: 2.4.0 (installed 2.4.0)
  - polls: 7.0.3 (installed 7.0.3)
  - richdocumentscode: 24.4.201 (installed 24.4.201)
  - support: 1.11.1 (installed 1.6.0)
  - survey_client: 1.16.0 (installed 1.7.0)
  - suspicious_login: 6.0.0
  - user_ldap: 1.19.0
  - weather_status: 1.8.0 (installed 1.0.0)

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

No response

Additional info

No response

@Gielovic Gielovic added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels May 23, 2024
@Gielovic Gielovic changed the title [Bug]: Comment is added to the wrong file when adding @mention [Bug]: Comment is added to the wrong file when not explicitly closing file details May 23, 2024
@joshtrichards
Copy link
Member

Sounds like nextcloud/activity#1772

@joshtrichards
Copy link
Member

Duplicate of nextcloud/activity#1772

@joshtrichards joshtrichards closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 28-feedback bug feature: comments feature: files
Projects
None yet
Development

No branches or pull requests

3 participants