Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout of error page broken #4837

Closed
schiessle opened this issue May 12, 2017 · 8 comments
Closed

Layout of error page broken #4837

schiessle opened this issue May 12, 2017 · 8 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug needs info regression
Milestone
Nextcloud 12.0

Comments

@schiessle
Copy link
Member

The layout of the error pages is broken:

core/template/403.php:

forbidden error

core/template/error.php

error page

cc @nextcloud/designers
@schiessle schiessle added bug design Design, UI, UX, etc. regression labels May 12, 2017
@schiessle schiessle added this to the Nextcloud 12.0 milestone May 12, 2017
@eppfel
Copy link
Member

eppfel commented May 12, 2017

I can not reproduce the error pages, because I only get redirects and not error pages...
How do I reproduce the error?

@MorrisJobke
Copy link
Member

core/template/403.php:

This is not supported anymore. We always render it through index.php.

@MorrisJobke
Copy link
Member

core/template/error.php

Same here. Not supported.

@MorrisJobke
Copy link
Member

See #3847

@MorrisJobke
Copy link
Member

This is the 404 page I got when going to a non existing share:

bildschirmfoto 2017-05-12 um 11 16 38

@eppfel eppfel added 1. to develop Accepted and waiting to be taken care of and removed design Design, UI, UX, etc. labels May 12, 2017
@MorrisJobke
Copy link
Member

The layout of the error pages is broken

@schiessle How did you get there?

@MorrisJobke
Copy link
Member

https://github.com/nextcloud/documentation/pull/392/files

@ChristophWurst ChristophWurst added 0. Needs triage Pending check for reproducibility or if it fits our roadmap needs info and removed 1. to develop Accepted and waiting to be taken care of labels May 15, 2017
@schiessle
Copy link
Member Author

@MorrisJobke looked for a existing template and used it here: 63593f9#diff-652646310472be421d6b80289b907cb8R167

So I will use something different here.

@nextcloud-bot nextcloud-bot mentioned this issue Jul 25, 2018
Closed
@nextcloud-bot nextcloud-bot mentioned this issue Aug 3, 2018
Closed
@nextcloud-bot nextcloud-bot mentioned this issue Aug 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug needs info regression
Projects
None yet
Milestone
Nextcloud 12.0
Development

No branches or pull requests
4 participants
@MorrisJobke @ChristophWurst @schiessle @eppfel