Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password change behavior #5181

Closed
AykutCevik opened this issue May 30, 2017 · 5 comments
Closed

Password change behavior #5181

AykutCevik opened this issue May 30, 2017 · 5 comments

Comments

@AykutCevik
Copy link

As mentioned by @eppfel in #4839 I would like to suggest a modification in the password change process.
It would be great to add one more field to verify the newly entered password (repeat new password). I have file encryption enabled and recovery set to false which means if I make a mistake while entering the password once, all my data will be lost unrecoverable.
Or do I miss something here?
Also viewing the plain text of the password to review it is not always a suitable solution.

Thank you guys for your awesome work!

@MorrisJobke
Copy link
Member

cc @jancborchardt for this

@jancborchardt
Copy link
Member

Viewing the password in plain text is the best solution to quickly absolutely make sure that your password is correct. The attack vector of being able to check your screen or keyboard is even amplified in the case where you would repeat your password, as there people can check out the screen/keyboard twice.

@AykutCevik
Copy link
Author

Can't confirm this actually. Had a colleague sitting next to me and couldn't check my password in this case. Also I can't view my entered password entirely:

image

@J0WI
Copy link
Contributor

J0WI commented Jan 7, 2019

Seems to be a duplicate of #3565

@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Jan 7, 2019
@MorrisJobke
Copy link
Member

Seems to be a duplicate of #3565

Correct -> let's close this here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants