Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contacts can't handle contact picture if TYPE is missing #539

Closed
minils opened this issue Jul 24, 2016 · 2 comments
Closed

Contacts can't handle contact picture if TYPE is missing #539

minils opened this issue Jul 24, 2016 · 2 comments
Labels
enhancement stale Ticket or PR with no recent activity

Comments

@minils
Copy link

minils commented Jul 24, 2016

Steps to reproduce

  1. Import a VCF File including contacts with the tag
PHOTO;ENCODING=BASE64;JPEG:/9j/...

(Some programs omit the TYPE= attribute)
2. Contact pictures don't get included.

Expected behaviour

The pictures should still be imported.
If the first line of the picture is:

PHOTO;ENCODING=BASE64;JPEG:/9j/...

instead of:

PHOTO;ENCODING=BASE64;TYPE=JPEG:/9j/...

Actual behaviour

The pictures are not imported at all.

Server configuration

Operating system: Debian 8

Web server: nginx 1.6.2

Database: mysql 5.5.50-0+deb8u1

PHP version: PHP 5.6.23-0+deb8u1

Nextcloud version: 9.0.52

Updated from an older Nextcloud/ownCloud or fresh install: Updated from ownCloud 9.0.2

Where did you install Nextcloud from: From tar ball

List of activated apps:

App list

Enabled:
  - activity: 2.2.1
  - admin_audit: 1.0.0
  - calendar: 1.2.2
  - comments: 0.2
  - contacts: 1.3.1.0
  - dav: 0.1.6
  - documents: 0.12.0
  - federatedfilesharing: 0.1.0
  - federation: 0.0.4
  - files: 1.4.4
  - files_pdfviewer: 0.8.1
  - files_sharing: 0.9.1
  - files_texteditor: 2.1
  - files_trashbin: 0.8.0
  - files_versions: 1.2.0
  - files_videoplayer: 0.9.8
  - firstrunwizard: 1.1
  - gallery: 14.5.0
  - notifications: 0.2.3
  - password_policy: 1.0.0
  - provisioning_api: 0.4.1
  - systemtags: 0.2
  - templateeditor: 0.1
  - theming: 0.1.0
  - updatenotification: 0.1.0
### Client configuration

Browser: Mozilla Firefox 47.0.1

Operating system: Fedora 24

@minils minils changed the title Contacts can't handle conact picture in base64 including newlines Contacts can't handle contact picture if TYPE is missing Jul 24, 2016
@MorrisJobke
Copy link
Member

cc @georgehrke

@skjnldsv
Copy link
Member

skjnldsv commented Jun 5, 2019

PHOTO;ENCODING=BASE64;JPEG:/9j/...
PHOTO;ENCODING=BASE64;TYPE=JPEG:/9j/...

Neither of them are valid according to the rfc.
https://tools.ietf.org/html/rfc6350#section-6.2.4
https://tools.ietf.org/html/rfc2426#section-3.1.4

So we are compliant with the carddav rules

@skjnldsv skjnldsv closed this as completed Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement stale Ticket or PR with no recent activity
Projects
None yet
Development

No branches or pull requests

4 participants