Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI problem in sharing options #5916

Closed
GitHubUser4234 opened this issue Jul 28, 2017 · 8 comments · Fixed by #7211
Closed

UI problem in sharing options #5916

GitHubUser4234 opened this issue Jul 28, 2017 · 8 comments · Fixed by #7211
Assignees
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc. feature: sharing good first issue Small tasks with clear documentation about how and in which place you need to fix things in. high regression
Milestone

Comments

@GitHubUser4234
Copy link
Contributor

Hi,

In NC12, after a user has unchecked "Can create" checkbox in the sharing options of a folder, it looks like he cannot uncheck the "Can change" checkbox subsequently. The whole page has to be refreshed for him to be able to uncheck the "Can change" checkbox also. If the page is not refreshed, the only thing that visibly happens is that all checkboxes are disabled briefly and then enabled again.

@MariusBluem
Copy link
Member

Could you please follow our issue template in the future? This helps us to reproduce issues more effective and faster ;) Please provide us some details about your environment (browser, ...), thanks!

@GitHubUser4234
Copy link
Contributor Author

GitHubUser4234 commented Jul 31, 2017

@MariusBluem Here is a gif where the issue can be quickly seen (gif might take a while to load). For each successful unchecking of a checkbox, the whole page needs to be refreshed (there are 2 refreshes in this gif):

ice_video_20170731-150249 1

Browsers used: Chrome 60.0.3112.78 and Firefox 54.0.1
OS: Windows 10 Pro 64bit

@guiweber
Copy link

I am also seeing this on my setup. Let me know if more information would help.

Server configuration

Operating system: Fedora 26
**Web server: Apache 2.4.27
**Database: MariaDB
**PHP version: 7.1.8
Nextcloud version: 12.0.2
Updated from an older Nextcloud/ownCloud or fresh install: Updated from 12.0.0
Where did you install Nextcloud from: Web Installer

Client configuration

Browser: Firefox 55.0.2
Operating system: Windows 10

@MorrisJobke MorrisJobke added bug and removed needs info labels Sep 3, 2017
@MorrisJobke
Copy link
Member

Maybe somebody from @nextcloud/javascript want to look into this

@MorrisJobke MorrisJobke added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label Sep 3, 2017
@skjnldsv
Copy link
Member

skjnldsv commented Sep 4, 2017

Can't reproduce on 13.
The can edit check is behaving as required.

@MorrisJobke
Copy link
Member

@skjnldsv Could you test 12 as well please? :)

@skjnldsv skjnldsv self-assigned this Nov 5, 2017
@skjnldsv skjnldsv added this to the Nextcloud 12.0.4 milestone Nov 5, 2017
@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Nov 8, 2017
@skjnldsv
Copy link
Member

skjnldsv commented Nov 8, 2017

Can confirm on stable12!
And actually, I can confirm on master13 too! ⚠️
This only applies to the checkboxes in the popover.

https://github.com/nextcloud/server/blob/e9ab452ff37f8ea606934bcc3323047d75d20e4a/core/js/sharedialogshareelistview.js

@blizzz @schiessle ?

@blizzz blizzz assigned blizzz and unassigned skjnldsv Nov 17, 2017
@blizzz
Copy link
Member

blizzz commented Nov 17, 2017

Fix in #7211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc. feature: sharing good first issue Small tasks with clear documentation about how and in which place you need to fix things in. high regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants