Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate app management code #8505

Open
MorrisJobke opened this issue Feb 22, 2018 · 6 comments
Open

Consolidate app management code #8505

MorrisJobke opened this issue Feb 22, 2018 · 6 comments

Comments

@MorrisJobke
Copy link
Member

Currently the code for managing app (install, update, remove, upgradability, fetching info, ...) is distributed across 3 classes:

  • OC_App
  • OC\App\AppManager
  • OC\Installer

We should consolidate this into a single class to not spread code and functionality as well as reduce the risk to re-implement existing code, because it is no obvious where to find which code.

@MorrisJobke
Copy link
Member Author

cc @nickvergessen @rullzer @blizzz FYI ;)

@nickvergessen
Copy link
Member

Sounds good 👍

@MorrisJobke
Copy link
Member Author

One little step is already done in #5833

@MorrisJobke
Copy link
Member Author

From #8506 (comment)

Learned some funny things about our terminology the hard way:

  • isInstalled, getInstalledApps, isEnabledForUser
  • first and last one check if the app is enabled
  • the other one checks if the app code is present in any of the apps folders 🙈

I added a little PHPDoc comment and we should look into unify this stuff.

@MorrisJobke
Copy link
Member Author

See also #9324

@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 20, 2018
@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Jun 25, 2018
@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jul 26, 2018
@ghost ghost closed this as completed Jun 12, 2019
@kesselb kesselb reopened this Jun 12, 2019
@ghost ghost removed the stale Ticket or PR with no recent activity label Jun 12, 2019
@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Jun 12, 2019
@szaimen

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants