Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to visually determine selected tab in file details view when using keyboard navigation #9944

Closed
kevgathuku opened this issue Jun 21, 2018 · 6 comments
Labels
Milestone

Comments

@kevgathuku
Copy link
Contributor

Steps to reproduce

  1. Open the files view. For any file, open the file details view
  2. Try to navigate the tabs (Activities, Comments, Sharing, Versions) using the keyboard
  3. Nothing visible is happening. It is unclear which element currently has focus

Expected behaviour

The tab element in focus should have a visible outline around it to enable the user to visually determine the component on which keyboard operations will interact at any point in time.

screen shot 2018-06-21 at 12 01 29

☝️ expected output when the sharing tab is focused with the keyboard

Actual behaviour

There is no visual indicator of the element that currently has keyboard focus
screen shot 2018-06-21 at 12 00 57

For this image, when a user interacts with the keyboard, it is not possible to tell which element they would be interacting with.

Server configuration

Operating system: Ubuntu 16.04

Nextcloud version: 13.0.4

Updated from an older Nextcloud/ownCloud or fresh install: Fresh install

Where did you install Nextcloud from: snap install nextcloud

@nextcloud-bot nextcloud-bot added the design Design, UI, UX, etc. label Jun 21, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #2096 (Readability / Distinction of currently selected element on right sidebar), #3632 (Unable to login using FreeIPA users with 2FA Enabled), #9005 (c), #9154 (Unable to use SCSS for apps which operate on the login screen), and #3049 (Hiding navigation bar).

@MorrisJobke
Copy link
Member

cc @nextcloud/designers

@jancborchardt
Copy link
Member

@kevgathuku thank you for the feedback, I will look into it! :) You are also welcome to contribute a fix if you like, I am happy to help.

@kevgathuku
Copy link
Contributor Author

Thanks @jancborchardt
I'll work on a fix, and I'll make sure to ask any questions that may come up 😃

@kevgathuku kevgathuku changed the title Unable to visually determine selected element when using keyboard navigation Unable to visually determine selected tab in file details view when using keyboard navigation Jun 26, 2018
@kevgathuku
Copy link
Contributor Author

Fixed in #9956

@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone Jun 26, 2018
@jancborchardt
Copy link
Member

It’s awesome when the person who finds the issue also fixes it! :) High five @kevgathuku

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants