Only check path for being accessible when the storage is a object home #24103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
requested review from
rullzer,
MorrisJobke,
icewind1991 and
kesselb
rullzer
approved these changes
Nov 17, 2020
MorrisJobke
approved these changes
Nov 19, 2020
|
@juliushaertl Backport? |
|
/backport to stable20 |
|
/backport to stable19 |
|
/backport to stable18 |
This comment has been minimized.
This comment has been minimized.
mejo-
added a commit
to nextcloud/deck
that referenced
this pull request
Jul 2, 2024
Forward-ported nextcloud/server#24103 Signed-off-by: Jonas <jonas@freesources.org>
2 tasks
mejo-
added a commit
to nextcloud/spreed
that referenced
this pull request
Jul 2, 2024
Forward-ported nextcloud/server#24103 Signed-off-by: Jonas <jonas@freesources.org> Signed-off-by: Jonas <jonas@freesources.org>
Merged
5 tasks
mejo-
added a commit
to nextcloud/spreed
that referenced
this pull request
Jul 2, 2024
…s a object home Forward-ported nextcloud/server#24103 Signed-off-by: Jonas <jonas@freesources.org> Signed-off-by: Jonas <jonas@freesources.org>
backportbot bot
pushed a commit
to nextcloud/deck
that referenced
this pull request
Jul 2, 2024
Forward-ported nextcloud/server#24103 Signed-off-by: Jonas <jonas@freesources.org>
backportbot bot
pushed a commit
to nextcloud/deck
that referenced
this pull request
Jul 2, 2024
Forward-ported nextcloud/server#24103 Signed-off-by: Jonas <jonas@freesources.org>
backportbot bot
pushed a commit
to nextcloud/spreed
that referenced
this pull request
Jul 2, 2024
…s a object home Forward-ported nextcloud/server#24103 Signed-off-by: Jonas <jonas@freesources.org> Signed-off-by: Jonas <jonas@freesources.org>
backportbot bot
pushed a commit
to nextcloud/spreed
that referenced
this pull request
Jul 2, 2024
…s a object home Forward-ported nextcloud/server#24103 Signed-off-by: Jonas <jonas@freesources.org> Signed-off-by: Jonas <jonas@freesources.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where shares originating from groupfolders were not showing up at the recipient due to the check for a valid "files" path being applied to all object storages instead of just the user ones.
For groupfolders the storage would be something like
object::store:amazon::nc-65a6889e4cd6where the previous check caused a false positive.