Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make files drop more visible #3784

Closed
wants to merge 1 commit into from
Closed

Make files drop more visible #3784

wants to merge 1 commit into from

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Mar 9, 2017

Implement the suggestions from #2207

Somebody with CSS magic should make it look not ugly. @nextcloud/designers

radio

@rullzer rullzer added this to the Nextcloud 12.0 milestone Mar 9, 2017
@mention-bot
Copy link

@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @blizzz, @schiessle and @LukasReschke to be potential reviewers.

@rullzer rullzer changed the title Make files drop more permanent Make files drop more visible Mar 9, 2017
@blizzz
Copy link
Member

blizzz commented Mar 17, 2017

Somebody with CSS magic should make it look not ugly. @nextcloud/designers

→ Rather Developing state then?

@rullzer rullzer added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 17, 2017
@MorrisJobke
Copy link
Member

Rebased on current master

@codecov-io
Copy link

codecov-io commented Mar 26, 2017

Codecov Report

Merging #3784 into master will increase coverage by <.01%.
The diff coverage is 55.55%.

@@             Coverage Diff             @@
##             master   #3784      +/-   ##
===========================================
+ Coverage      54.2%   54.2%   +<.01%     
  Complexity    21294   21294              
===========================================
  Files          1310    1310              
  Lines         81253   81251       -2     
  Branches       1285    1283       -2     
===========================================
+ Hits          44043   44046       +3     
+ Misses        37210   37205       -5
Impacted Files Coverage Δ Complexity Δ
core/js/sharedialoglinkshareview.js 55.23% <50%> (+3.01%) 0 <0> (ø) ⬇️
core/js/shareitemmodel.js 82.95% <66.66%> (-1.34%) 0 <0> (ø)
apps/files_trashbin/lib/Trashbin.php 73.39% <0%> (-0.25%) 133% <0%> (ø)
apps/comments/lib/EventHandler.php 87.5% <0%> (+8.33%) 7% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e26f138...3b68974. Read the comment docs.

@rullzer
Copy link
Member Author

rullzer commented Mar 27, 2017

@jancborchardt care to take a look? Or should I close this?

@jancborchardt
Copy link
Member

Yep I will check. :) Can you rebase on master and fix the conflict?

Implement the suggestions from #2207

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Copy link
Member Author

rullzer commented Mar 28, 2017

@jancborchardt done

@MorrisJobke
Copy link
Member

@jancborchardt Ping

@rullzer
Copy link
Member Author

rullzer commented Apr 12, 2017

So no action here... closing... please reopen if somebody wants to work on it still.

@rullzer rullzer closed this Apr 12, 2017
@rullzer rullzer deleted the link_radio branch April 12, 2017 20:40
@Espina2
Copy link
Contributor

Espina2 commented Apr 12, 2017

| show here how to improve this feature.

#4273

@MorrisJobke
Copy link
Member

| show here how to improve this feature.

The problem here is, that we need some CSS help from @jancborchardt but he is ignoring this ticket somehow. :/

@Espina2
Copy link
Contributor

Espina2 commented Apr 13, 2017

I can help with that, if hou help me setup a dev enviroment on my machine.

@eppfel
Copy link
Member

eppfel commented Apr 21, 2017

@Espina2 This might work:

git clone git@github.com:nextcloud/server.git
cd server
git submodule update --init
php -S localhost:8080

Then you should be able do run the setup in the browser...

Maybe you need to update php.

I have an unfinished / partly obsolete documentation for more: https://pad.epp.cloud/s/B1vqv1fMe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants