From 83b646bc7e03af4c4408eebf84fa8bbb76efa7a7 Mon Sep 17 00:00:00 2001 From: Bram Date: Wed, 4 Oct 2023 03:21:54 +0200 Subject: [PATCH] fix(OC_Template.php): ensure we throw all errors In one branch of the try/catch combination, in one specific path no error was thrown at all, thus the user ended up with a 500 error page online but absolutely no error anyway in the logs. Signed-off-by: Bram --- lib/private/legacy/OC_Template.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/private/legacy/OC_Template.php b/lib/private/legacy/OC_Template.php index 974f26fa38122..0816719b8cfae 100644 --- a/lib/private/legacy/OC_Template.php +++ b/lib/private/legacy/OC_Template.php @@ -311,6 +311,9 @@ public static function printExceptionErrorPage($exception, $statusCode = 503) { print("The server encountered an internal error and was unable to complete your request.\n"); print("Please contact the server administrator if this error reappears multiple times, please include the technical details below in your report.\n"); print("More details can be found in the server log.\n"); + + // and then throw it again to log it at least to the web server error log + throw $e; } die(); }