From 8d57cdcab5969e569faa8bb519442b91a43102bd Mon Sep 17 00:00:00 2001 From: Ferdinand Thiessen Date: Tue, 17 Oct 2023 15:10:31 +0200 Subject: [PATCH] fix(theming): Add `aria-pressed` attribute to active background Signed-off-by: Ferdinand Thiessen --- apps/theming/src/UserThemes.vue | 6 ++-- .../src/components/BackgroundSettings.vue | 31 +++++++++++----- cypress/e2e/theming/user-background.cy.ts | 36 +++++++++++++++---- dist/614-614.js | 4 +-- dist/614-614.js.map | 2 +- dist/core-unsupported-browser.js | 4 +-- dist/core-unsupported-browser.js.map | 2 +- dist/theming-personal-theming.js | 4 +-- dist/theming-personal-theming.js.map | 2 +- 9 files changed, 65 insertions(+), 26 deletions(-) diff --git a/apps/theming/src/UserThemes.vue b/apps/theming/src/UserThemes.vue index eb2c4d19547f2..be76f02563df1 100644 --- a/apps/theming/src/UserThemes.vue +++ b/apps/theming/src/UserThemes.vue @@ -26,7 +26,9 @@ +

+

@@ -133,7 +135,7 @@ export default { // using the `t` replace method escape html, we have to do it manually :/ return t( 'theming', - 'Universal access is very important to us. We follow web standards and check to make everything usable also without mouse, and assistive software such as screenreaders. We aim to be compliant with the {guidelines}Web Content Accessibility Guidelines{linkend} 2.1 on AA level, with the high contrast theme even on AAA level.' + 'Universal access is very important to us. We follow web standards and check to make everything usable also without mouse, and assistive software such as screenreaders. We aim to be compliant with the {guidelines}Web Content Accessibility Guidelines{linkend} 2.1 on AA level, with the high contrast theme even on AAA level.', ) .replace('{guidelines}', this.guidelinesLink) .replace('{linkend}', '') @@ -146,7 +148,7 @@ export default { descriptionDetail() { return t( 'theming', - 'If you find any issues, do not hesitate to report them on {issuetracker}our issue tracker{linkend}. And if you want to get involved, come join {designteam}our design team{linkend}!' + 'If you find any issues, do not hesitate to report them on {issuetracker}our issue tracker{linkend}. And if you want to get involved, come join {designteam}our design team{linkend}!', ) .replace('{issuetracker}', this.issuetrackerLink) .replace('{designteam}', this.designteamLink) diff --git a/apps/theming/src/components/BackgroundSettings.vue b/apps/theming/src/components/BackgroundSettings.vue index 830d25bf956b0..d12489b0587c0 100644 --- a/apps/theming/src/components/BackgroundSettings.vue +++ b/apps/theming/src/components/BackgroundSettings.vue @@ -26,8 +26,12 @@