Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): Allow to search in a dedicated other conversation with a filter #11456

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen
Copy link
Member Author

CS fix:

diff --git a/lib/Search/MessageSearch.php b/lib/Search/MessageSearch.php
index 77212af91..1714a6250 100644
--- a/lib/Search/MessageSearch.php
+++ b/lib/Search/MessageSearch.php
@@ -127,7 +127,7 @@ class MessageSearch implements IProvider, IFilteringProvider {
                        } catch (RoomNotFoundException) {
                                return SearchResult::complete($title, []);
                        }
-               } else if ($filter) {
+               } elseif ($filter) {
                        // The filter is the "Current conversation" so the CurrentMessageSearch will handle it
                        return SearchResult::complete($title, []);
                } else {

…a filter

Signed-off-by: Joas Schilling <coding@schilljs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants