Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Reactions): add All button #11508

Merged
merged 4 commits into from
Feb 10, 2024
Merged

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Feb 1, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Ordered historically

🏚️ Button 🏡 Modal
image image

🚧 Tasks

TODO:

  • Guest icon should not have "G" if it refers to "guest"

  • Code review

  • Design review

🏁 Checklist

@Antreesy

This comment was marked as resolved.

@DorraJaouad DorraJaouad force-pushed the feat/7139/add-all-reactions-button branch from 7de8cce to 1b4b625 Compare February 8, 2024 12:49
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking from my side, all nicely done. Let's wait for the design input

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the feat/7139/add-all-reactions-button branch from 1b4b625 to 91c2aad Compare February 9, 2024 07:23
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! I would agree with @Antreesy suggestion to use the heart character with a counter like telegram does.
I would also remove the border between the tabs and the list in the dialog

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the feat/7139/add-all-reactions-button branch 3 times, most recently from 421c517 to 2eccd45 Compare February 9, 2024 17:41
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the feat/7139/add-all-reactions-button branch from 2eccd45 to 47b50a5 Compare February 9, 2024 20:47
@DorraJaouad DorraJaouad merged commit 06af154 into main Feb 10, 2024
37 checks passed
@DorraJaouad DorraJaouad deleted the feat/7139/add-all-reactions-button branch February 10, 2024 08:43
@nickvergessen
Copy link
Member

Seeing it the first time in use now, I think we should change 2 things:
grafik

  • Hide the button similarly like the "Emoji plus" when the message is not hovered/focused
  • To avoid jumping with above change, move the heart to the end between the reactions and the "Emoji plus"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Not possible to see all reactions
4 participants