-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Reactions): add All button #11508
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
src/components/MessagesList/MessagesGroup/Message/MessagePart/Reactions.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/ReactionsList.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/Reactions.vue
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/Reactions.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/ReactionsList.vue
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/ReactionsList.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/ReactionsList.vue
Show resolved
Hide resolved
7de8cce
to
1b4b625
Compare
src/components/MessagesList/MessagesGroup/Message/MessagePart/Reactions.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/ReactionsList.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing blocking from my side, all nicely done. Let's wait for the design input
src/components/MessagesList/MessagesGroup/Message/MessagePart/ReactionsList.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/ReactionsList.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/ReactionsList.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/Reactions.vue
Show resolved
Hide resolved
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
1b4b625
to
91c2aad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! I would agree with @Antreesy suggestion to use the heart character with a counter like telegram does.
I would also remove the border between the tabs and the list in the dialog
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
421c517
to
2eccd45
Compare
src/components/MessagesList/MessagesGroup/Message/MessagePart/Reactions.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/Reactions.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/ReactionsList.vue
Outdated
Show resolved
Hide resolved
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
2eccd45
to
47b50a5
Compare
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Ordered historically
🚧 Tasks
TODO:
Guest icon should not have "G" if it refers to "guest"
Code review
Design review
🏁 Checklist