Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-pretty URLs for federated server URL #12888

Closed
SystemKeeper opened this issue Aug 2, 2024 · 3 comments
Closed

Handle non-pretty URLs for federated server URL #12888

SystemKeeper opened this issue Aug 2, 2024 · 3 comments

Comments

@SystemKeeper
Copy link
Contributor

Ref:

url: this._getBackendUrl(this.settings.federation.nextcloudServer),

Since we don't include a possible index.php for nextcloudServer:

'nextcloudServer' => $room->getRemoteServer(),

There is a possibility, that the remote server does not support pretty URLs and signaling federation fails, because the requests can't be made.

This the URL is generated here in talk:

Signaling.Standalone.prototype._getBackendUrl = function(baseURL = undefined) {
return generateOcsUrl('apps/spreed/api/v3/signaling/backend', {}, { baseURL })
}

And here in the lib:
https://github.com/nextcloud-libraries/nextcloud-router/blob/5b8e1711fbaaf9d5f8a68514f741f46361b69570/lib/index.ts#L118-L141

It seems we could just pass noRewrite: true as options, to always have an index.php in the URL, as currently it is determined by our own server support.
This also needs to be done on the clients.

@SystemKeeper
Copy link
Contributor Author

ocs calls don't use index.php -> no issue here.

@SystemKeeper SystemKeeper closed this as not planned Won't fix, can't repro, duplicate, stale Aug 2, 2024
@nickvergessen
Copy link
Member

That being said, iirc federation doesn't work at all atm without beautiful urls: nextcloud/server#41234

@SystemKeeper
Copy link
Contributor Author

Ah right, the removal of the ocm-provider directory...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
Development

No branches or pull requests

2 participants