-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External link preview #3156
Comments
@PVince81 |
This is not (only) about internal items. Any link should show the OpenGraph Information when available. |
yes sure, but maybe it's an easy step to start with internal link because there we have previews already |
|
Just as a summary. We are currently facing the decision whether this should leak/violate the privacy of the server or the users. So it might be necessary to allow admins to specify if the nextcloud server can be used as a proxy and at the same time a user option is needed as you can use this to track reading. |
Ideally, this needs to be done on the server and as soon as the message is sent, to make sure this can't be used for read-tracking. But this is tricky to implement and there are many possible pitfalls. One of them affected Mastodon, that had the problem that then a popular account was sending a link, the preview ddos-ed the URL since many Mastodon instances were suddenly doing a request for a preview. See mastodon/mastodon#4486 for context Doing it on the server is also what Telegram and Matrix do. For Matrix, an API is exposed by the server to fetch the metadata: https://matrix.org/docs/spec/client_server/r0.6.1#get-matrix-media-r0-preview-url and should actually not be used in encrypted rooms. |
I would say it makes the most sense to leak the server IP and cache it server side, as this leaks the least information (the number of readers and the time of reading is not leaked, only the time of posting). |
// What stage is the development of this feature at? Is it possible to independently implement this function without waiting for a full-fledged update of the platform? |
This was implemented by @juliushaertl #7822 :) |
Or should this be kept open for video previews? @nickvergessen your call, or if it should be a separate issue to focus on what’s left. |
No, all fixed. Anything new will come in with a lib update and should come without bigger todos on our side. |
Is your feature request related to a problem? Please describe.
When fast talking, like in brainstorms, there is the need to just push images, videos and text docs into the conversation. Most of the time, without the need to open the link just to see the idea. Actually, opening the link is most of the times a waste of time since we're just passing an idea or a concept.
Describe the solution you'd like
It would be a great deal to have external link previews, like in other messengers, where they load a thumbnail of the page, image or video.
Describe alternatives you've considered
None.
Additional context
None.
The text was updated successfully, but these errors were encountered: