Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External link preview #3156

Closed
mtadeunet opened this issue Mar 25, 2020 · 11 comments
Closed

External link preview #3156

mtadeunet opened this issue Mar 25, 2020 · 11 comments
Assignees

Comments

@mtadeunet
Copy link

Is your feature request related to a problem? Please describe.
When fast talking, like in brainstorms, there is the need to just push images, videos and text docs into the conversation. Most of the time, without the need to open the link just to see the idea. Actually, opening the link is most of the times a waste of time since we're just passing an idea or a concept.

Describe the solution you'd like
It would be a great deal to have external link previews, like in other messengers, where they load a thumbnail of the page, image or video.

Describe alternatives you've considered
None.

Additional context
None.

@jakobroehrl
Copy link
Contributor

@PVince81
Do you see an possibility to create a file preview for a message with a internal link?
In theory we have a preview for every file, so we only need to show it, right?

@nickvergessen
Copy link
Member

This is not (only) about internal items. Any link should show the OpenGraph Information when available.

@jakobroehrl
Copy link
Contributor

yes sure, but maybe it's an easy step to start with internal link because there we have previews already

@jakobroehrl jakobroehrl removed their assignment Jun 17, 2021
@gurbain
Copy link

gurbain commented Oct 25, 2021

  • 1 for such a feature! We are trying to move from Mattermost to spreed, and previewing external URL is undeniably an important missing feature for us.

@nickvergessen
Copy link
Member

Just as a summary. We are currently facing the decision whether this should leak/violate the privacy of the server or the users.
Either the clients do the request then their IP+ is leaked to the server, or the Nextcloud server proxies it but then its IP+ is leaked.

So it might be necessary to allow admins to specify if the nextcloud server can be used as a proxy and at the same time a user option is needed as you can use this to track reading.

@CarlSchwan
Copy link
Member

CarlSchwan commented Nov 30, 2021

Ideally, this needs to be done on the server and as soon as the message is sent, to make sure this can't be used for read-tracking. But this is tricky to implement and there are many possible pitfalls.

One of them affected Mastodon, that had the problem that then a popular account was sending a link, the preview ddos-ed the URL since many Mastodon instances were suddenly doing a request for a preview. See mastodon/mastodon#4486 for context

Doing it on the server is also what Telegram and Matrix do. For Matrix, an API is exposed by the server to fetch the metadata: https://matrix.org/docs/spec/client_server/r0.6.1#get-matrix-media-r0-preview-url and should actually not be used in encrypted rooms.

@come-nc
Copy link
Contributor

come-nc commented Nov 30, 2021

Just as a summary. We are currently facing the decision whether this should leak/violate the privacy of the server or the users. Either the clients do the request then their IP+ is leaked to the server, or the Nextcloud server proxies it but then its IP+ is leaked.

So it might be necessary to allow admins to specify if the nextcloud server can be used as a proxy and at the same time a user option is needed as you can use this to track reading.

I would say it makes the most sense to leak the server IP and cache it server side, as this leaks the least information (the number of readers and the time of reading is not leaked, only the time of posting).

@webagroprom
Copy link

This is not (only) about internal items. Any link should show the OpenGraph Information when available.

Just as a summary. We are currently facing the decision whether this should leak/violate the privacy of the server or the users. Either the clients do the request then their IP+ is leaked to the server, or the Nextcloud server proxies it but then its IP+ is leaked.

So it might be necessary to allow admins to specify if the nextcloud server can be used as a proxy and at the same time a user option is needed as you can use this to track reading.

//

What stage is the development of this feature at?
In what version will the preview of external links in the conference appear?

Is it possible to independently implement this function without waiting for a full-fledged update of the platform?

@jancborchardt
Copy link
Member

This was implemented by @juliushaertl #7822 :)

@jancborchardt
Copy link
Member

Or should this be kept open for video previews? @nickvergessen your call, or if it should be a separate issue to focus on what’s left.

@nickvergessen
Copy link
Member

No, all fixed. Anything new will come in with a lib update and should come without bigger todos on our side.

@nickvergessen nickvergessen moved this to 🧭 Planning evaluation (don't pick) in 💬 Talk team Sep 20, 2022
@nickvergessen nickvergessen moved this from 🧭 Planning evaluation (don't pick) to 🆕 Next Major Changelog in 💬 Talk team Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

9 participants