Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tapping notification should not join call with video by default #200

Closed
jancborchardt opened this issue Jun 18, 2018 · 6 comments
Closed
Labels
design Related to the design
Milestone

Comments

@jancborchardt
Copy link
Member

Currently, tapping the notification for a call joins that call by default, with the video on.

In the case of a group call this is very unexpected, especially since we changed the app to show the chat instead of directly joining the call. It would be good if tapping the notification would reflect that, first opening the chat. (Which could show a more prominent »Join call« button below the chat when a call is active.)

@jancborchardt jancborchardt added the design Related to the design label Jun 18, 2018
@mario
Copy link
Contributor

mario commented Jun 18, 2018

I'm currently refactoring and rewriting/rewiring the "incoming call" experience where you'll be able to select either voice or video response. Since it's an actual CALL (and not a chat message) people do expect to be able to join a call.

Let's see how you feel about this once this is ready for testing.

@mario
Copy link
Contributor

mario commented Jun 18, 2018

Edit: Yes, group calls are a bit special - but when I get a push notification, I don't know what type of a call it is, so that makes it a tricky. I'll explore how others do it and come back to you.

@mario
Copy link
Contributor

mario commented Jun 26, 2018

@jancborchardt thoughts on the beta?

@jancborchardt
Copy link
Member Author

Yup! :)

  • Great stuff with full-screen thing!
  • the avatar when you get a call from someone else should be even bigger – and when you accepted it and it’s a voice call, the avatar should be exactly the same size (bigger than now)
  • When you accept the call, it shouldn’t animate to the right but just morph the view (cause the buttons are basically the same) and replace the avatar with the video (or keep avatar, when it’s a video call)

Here’s a mockup of an improved background without the controls: Improved design of avatars in calls nextcloud/spreed#1011

@mario mario added this to the v2.1 milestone Jun 30, 2018
@mario
Copy link
Contributor

mario commented Jun 30, 2018

Closing this since the actual issue is solved. If you'd like other things, open separate issues and we can discuss.

@jancborchardt
Copy link
Member Author

Issue opened at #223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Related to the design
Projects
None yet
Development

No branches or pull requests

2 participants