Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus visible looks funny on headings #2921

Closed
max-nextcloud opened this issue Sep 15, 2022 · 2 comments · Fixed by #2922
Closed

Focus visible looks funny on headings #2921

max-nextcloud opened this issue Sep 15, 2022 · 2 comments · Fixed by #2922

Comments

@max-nextcloud
Copy link
Collaborator

Describe the bug
When focusing a heading it has a box around it with a little square at the lower left to make room for the # anchor:

Bildschirmfoto vom 2022-09-15 08-09-21

To Reproduce
Steps to reproduce the behavior:

  1. Go to a text file with headings
  2. Focus one of the headings
  3. See highlighting with funny shape

Expected behavior
I did not expect this to be highlighted at all - but i guess that's for accessibility reasons. If highlighted i would expect this to only have a clear rectangle around the heading itself.

@susnux
Copy link
Contributor

susnux commented Sep 15, 2022

Does this happens only in a specific browser? Because for me it looks correct using Firefox 104:
Correct highlight of border

Edit: I can reproduce this using Chrome.
Looks like we do not set any focus-visible styling, so the browser default is used, this is why this only affects Chrome.

@max-nextcloud
Copy link
Collaborator Author

Yes... I was seeing this in chrome as well. Thanks a lot for looking into this @susnux!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants