Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can no longer copy content from code blocks #5331

Closed
nickvergessen opened this issue Feb 2, 2024 · 5 comments · Fixed by #5487 or #5395
Closed

Can no longer copy content from code blocks #5331

nickvergessen opened this issue Feb 2, 2024 · 5 comments · Fixed by #5487 or #5395
Assignees

Comments

@nickvergessen
Copy link
Member

Describe the bug
Ref #5212

To Reproduce
Steps to reproduce the behavior:

  1. Have a collective page with a list and inside the list there is a code block:
* List item 1
* List item 2
    ```
    ### Workarounds
    
    <!-- Remove not applicable sections -->
    
    * Disable app X
    * Change config setting Y
    * No workaround available
    ```
  1. Copy bits inside the code block
  2. Paste any where

Expected behavior
You paste:

### Workarounds

<!-- Remove not applicable sections -->

* Disable app X
* Change config setting Y
* No workaround available

Actual behavior
You paste with list item and code block wrap
grafik

Screenshots
If applicable, add screenshots to help explain your problem.

@juliushaertl
Copy link
Member

One further related topic I've noticed is that copying a link that was pasted earlier results in a link wrapped in brackets <https://github.com/nextcloud/text/issues/5331>

@juliushaertl
Copy link
Member

@elzody Another suggestion from @susnux in #5212 (comment) might also be interesting to check if that is feasible

@elzody elzody linked a pull request Apr 8, 2024 that will close this issue
5 tasks
@elzody
Copy link
Contributor

elzody commented Apr 8, 2024

Closing since a workaround was implemented via #5395.
Keep an eye on #5487 for further iterations of getting the correct copy-paste behavior

@elzody elzody closed this as completed Apr 8, 2024
@susnux
Copy link
Contributor

susnux commented Apr 9, 2024

Closing since a workaround was implemented via #5395.

I do not think this is a workaround, this is in most cases not usable, because often the code block contains multiple entries and you only want to copy one. E.g. email addresses, shell commands etc.

ls -ahlp
cat foo.bar

Copying ls -ahlp should not result in ```ls -ahlp``` you can not use that directly but again need an editor to paste and copy only the selected text.

@elzody
Copy link
Contributor

elzody commented Apr 9, 2024

I do not think this is a workaround, this is in most cases not usable, because often the code block contains multiple entries and you only want to copy one. E.g. email addresses, shell commands etc.

Makes sense. I will reopen, we're trying to get #5487 merged as @max-nextcloud made some changes today and we can further iterate on it in the future. This specific issue and the one you described should be fixed once this happens.

Sorry for the confusion, just trying to get things a bit more organized around this

@elzody elzody reopened this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
5 participants