Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables button alignment is off on master #6027

Closed
juliushaertl opened this issue Jul 11, 2024 · 2 comments · Fixed by #6150
Closed

Tables button alignment is off on master #6027

juliushaertl opened this issue Jul 11, 2024 · 2 comments · Fixed by #6150
Assignees
Labels
1. to develop bug Something isn't working design Experience, interaction, interface, …

Comments

@juliushaertl
Copy link
Member

This is due to the design change coming with Nextcloud 30.

We probably need to adjust to use the css variables there as well:

Screenshot 2024-07-11 at 12 54 15
@juliushaertl juliushaertl added bug Something isn't working design Experience, interaction, interface, … 1. to develop labels Jul 11, 2024
@luka-nextcloud
Copy link
Contributor

@juliushaertl Is there any instruction which css variables should be updated? Is it https://help.nextcloud.com/t/css-variable-change-and-probable-regressions-in-apps/196999?

@juliushaertl
Copy link
Member Author

I'm not sure why the buttons are misaligned, but if there are any hardcoded height or margin/padding values it might be worth to adapt them to css variables.

  • height should probably be adapted to --default-clickable-area
  • padding/margin either try to align more dynamically with flex layouts or use a multiple of --default-grid-baseline

Also see https://docs.nextcloud.com/server/latest/developer_manual/html_css_design/css.html#css-variables for an overview on css variables and where to use them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop bug Something isn't working design Experience, interaction, interface, …
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants