Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User Verification (pin support) for CTAP2 enabled devices #41

Closed
s-f-s opened this issue Jun 11, 2020 · 5 comments · Fixed by #69
Closed

Add User Verification (pin support) for CTAP2 enabled devices #41

s-f-s opened this issue Jun 11, 2020 · 5 comments · Fixed by #69
Labels
enhancement New feature or request
Milestone

Comments

@s-f-s
Copy link

s-f-s commented Jun 11, 2020

It would be great to have support for "User Verification" with FIDO2 (CTAP2 enabled device) using a PIN.

https://www.w3.org/TR/webauthn/#user-verification

@michib michib added the enhancement New feature or request label Aug 20, 2020
@michib michib added this to the 0.3.0 milestone Aug 20, 2020
@My1
Copy link

My1 commented Sep 20, 2020

does the nextcloud let you enter the 2FA module without a password tho?
because that's kinda the purpose of the UV, to ax the password requirement.

@kowalski7cc
Copy link

kowalski7cc commented Mar 2, 2021

I think in this case authenticatorSelection.userVerification should be discouraged because this is already a second factor after password entry.
The verification required should be used in the Nextcloud passwordless login (nextcloud/server#21215), which at the moment is broken because it won't check for user verification and instead will bring you to a 2fa that could be the same used for the passwordless login (nextcloud/server#22982)

@My1
Copy link

My1 commented Jun 9, 2021

I think in this case authenticatorSelection.userVerification should be discouraged because this is already a second factor after password entry.
The verification required should be used in the Nextcloud passwordless login (nextcloud/server#21215), which at the moment is broken because it won't check for user verification and instead will bring you to a 2fa that could be the same used for the passwordless login (nextcloud/server#22982)

couldnt agree more.
preferred just kinda sux in general and is a kinda bad default.

I have written a bit about this already somewhere.
https://blog.my1.dev/webauthns-userverificationpreferred-and-its-pitfalls
I dont really wanna advertise anything but it's just easier than writing it all top to bottom into a comment.

@kowalski7cc
Copy link

@michib I have a commit here that discourages browsers to ask for user verification: https://github.com/kowalski7cc/nextcloud_twofactor_webauthn/commit/09c7c619107634646b06ab2c3d65776f1cbaa0fe
I'm testing it on my NC instance (It seems to work ok with Yubikey).
If you want I can open a PR.

@michib
Copy link
Collaborator

michib commented Sep 26, 2021

@kowalski7cc i would highly appreciate it. Thanks in advance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@s-f-s @kowalski7cc @michib @My1 and others