Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rmdir being invoked on non-empty dirs, resulting in failed updates #391

Closed
VVelox opened this issue Oct 3, 2021 · 2 comments
Closed

rmdir being invoked on non-empty dirs, resulting in failed updates #391

VVelox opened this issue Oct 3, 2021 · 2 comments
Labels
0. Needs triage bug feature: deletion Step 9

Comments

@VVelox
Copy link

VVelox commented Oct 3, 2021 

[Sun Oct 03 00:40:37.498715 2021] [fastcgi:error] [pid 14444] [client 192.168.15.2:14362] FastCGI: server "/home/thefog/www/php5-fcgis" stderr: PHP message: PHP Warning:  rmdir(/home/thefog/www/updater/../core/l10n): Directory not empty in /home/thefog/www/updater/index.php on line 1005

Please note that as per the PHP docs, directories must be empty for this command to work.

https://www.php.net/manual/en/function.rmdir.php
@VVelox
Copy link
Author

VVelox commented Oct 3, 2021

Looks like there is an issue with RecursiveDirectoryIterator in that it does not always start at the top of a tree with the data returned, but starts returning data at the base of the tree first, meaning rmdir will fail 100% of the time.

@joshtrichards
Copy link
Member

Duplicate of #158

Let's consolidate this matter there.

@joshtrichards joshtrichards closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. Needs triage bug feature: deletion Step 9
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshtrichards @VVelox